From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C562ACDB479 for ; Wed, 24 Jun 2026 15:34:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 150D410E8F2; Wed, 24 Jun 2026 15:34:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="oyQNmsCI"; dkim-atps=neutral Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB0E010E8F2 for ; Wed, 24 Jun 2026 15:34:27 +0000 (UTC) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id B6ACDC6B3B3; Wed, 24 Jun 2026 15:34:33 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id AB872601C5; Wed, 24 Jun 2026 15:34:25 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7EAC5106C8382; Wed, 24 Jun 2026 17:34:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1782315264; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=hQIzpvMfwF06Dy+Dr6X7XbgYJ2zdNKivwH5fV0BlR9A=; b=oyQNmsCIcNTgs68aF1WzEwUyaqMGrQDkkQYBeAFupUMciys441g2Pmpqb9q63M9TgB3z9E obW679sV3ac8zlACQM9Jmg/vA1v3ow+j/P/Xhfnreqz+gfsGN0Qft8YbEltzMW38iraK5G 9iEx3IU3pw62tpfcDlC29EJONLP21quC1Rlrlhpp4LfK2hpOrdisPqhb0sZ1oOElcLMo3u oTaeeKfmEJ1VM5c5SAWIaeFvOjdocre7HQHMPxIxunAsVG/t7aa/fRy61Zs8UWONtYA4mP QamLzEJxL0b9mjX7CEKx7PilFcaI1roV0COlX17AIapF6umjrYF86R9VRHohCg== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 24 Jun 2026 17:34:14 +0200 Message-Id: Cc: "Maarten Lankhorst" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "Laurent Pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Inki Dae" , "Jagan Teki" , "Marek Szyprowski" , "Marek Vasut" , "Stefan Agner" , "Frank Li" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "Hui Pu" , "Ian Ray" , "Thomas Petazzoni" , , , , To: "Maxime Ripard" , "Luca Ceresoli" From: "Luca Ceresoli" Subject: Re: [PATCH 15/37] drm/display: bridge-connector: allocate the connector dynamically X-Mailer: aerc 0.21.0 References: <20260519-drm-bridge-hotplug-v1-0-45e2bdb3dfb4@bootlin.com> <20260519-drm-bridge-hotplug-v1-15-45e2bdb3dfb4@bootlin.com> <20260608-rustling-infrared-turkey-e09af8@houat> <20260624-judicious-enigmatic-hippo-b13ffe@houat> In-Reply-To: <20260624-judicious-enigmatic-hippo-b13ffe@houat> X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Maxime, thanks for the feedback. On Wed Jun 24, 2026 at 1:48 PM CEST, Maxime Ripard wrote: > On Fri, Jun 12, 2026 at 02:44:43PM +0200, Luca Ceresoli wrote: >> On Mon Jun 8, 2026 at 1:46 PM CEST, Maxime Ripard wrote: >> > On Tue, May 19, 2026 at 12:37:32PM +0200, Luca Ceresoli wrote: >> >> Currently the drm_bridge_connector has an embedded drm_connector, so = their >> >> allocation lifetimes are tied to each other. This is insufficient to >> >> support DRM bridge hotplugging, which requires the connector to be ad= ded >> >> and removed dynamically at runtime multiple times based on hotplug/un= plug >> >> events while the drm_bridge_connector is persistent. >> >> >> >> Moreover the drm_connector is exposed to user space and thus an ongoi= ng >> >> operation (e.g. an ioctl) might last for an arbitrarily long time eve= n >> >> after the hardware gets removed. This means a new connector might hav= e to >> >> be added when the previous one is still referenced by user space. >> >> >> >> In preparation to handle hotplug, allocate the drm-connector dynamica= lly, >> >> to allow: >> >> >> >> * creating and destroying a connector multiple times during a single >> >> drm_bridge_connector lifetime >> >> * creating a new connector even though the previous one is still in = use >> >> and thus still refcounted and not yet freed >> >> >> >> This commit does not introduce the actions in the two bullets (it wil= l >> >> happen in a later commit), it only moves to dynamic APIs for connecto= r >> >> allocation and init. >> >> >> >> Signed-off-by: Luca Ceresoli >> > >> > I think this patch should be split in half, with the switch to using >> > destroy first, and then the actual move to the dynamically allocated >> > connector API. >> >> Is it doable? drm_connector_dynamic_init() mandates a .destroy callback, >> drm_connector_init() forbids it. > > drmm_connector_init forbids it. drm_connector_init mandates it. Something bogus in my reply, sorry. :) So you mean splitting in: * first patch: move from drmm_connector[_hdmi]_init() to drm_connector[_hdmi]_init() and add a .destroy * second patch: move from drm_connector[_hdmi]_init() to drm_connector[_hdmi]_dynamic_init() + drm_connector_dynamic_register/unregister() ? Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com