From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 177C3C4451C for ; Fri, 17 Jul 2026 12:20:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6AFD910E2CF; Fri, 17 Jul 2026 12:20:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="PJUj1kIZ"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 50AD310E2CF for ; Fri, 17 Jul 2026 12:20:30 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id E55EC402B8; Fri, 17 Jul 2026 12:20:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9D131F000E9; Fri, 17 Jul 2026 12:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784290829; bh=3zZRRumE1bYiKKWD7igY43RWBksfZ312lkH+RvumdzU=; h=Date:Subject:Cc:To:From:References:In-Reply-To; b=PJUj1kIZgI7tHJLjsSEFXzZe/B6PsC7PZR8Yl3AinHSLs97AgiIO0zCSmAg3d5nYY LSmWQ7xlpT7892vVtBtQgMVilrYkSdYhTlVrcGFpSZukSQ3EgytGbe5N0hl5xxXUJl evCftt4IH4VmHcsvajxttGCsd6SNWIkl0lfTzjrZcpx//KjjfQoTWjt3EF6p9G+qdF y5tNygDHk0nNP6x7Yq2yDGfV3INf2XYEpMeJmrY51EuTEEDhex7ZWzYTi3+PyMAPoN V70mrE1jdZk55I33VTXze402Qz49QR1CTXMvvZKWeZmpEW3hChZNI78o1AijdVyvUE foX1m9US/waJQ== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 17 Jul 2026 14:20:23 +0200 Message-Id: Subject: Re: [PATCH v14 0/3] rust: add basic serial device bus abstractions Cc: "Greg Kroah-Hartman" , "Markus Probst" , "Rob Herring" , "Jiri Slaby" , "Miguel Ojeda" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "Kari Argillander" , "Rafael J. Wysocki" , "Viresh Kumar" , "Boqun Feng" , "David Airlie" , "Simona Vetter" , "Daniel Almeida" , "Tamir Duberstein" , "Alexandre Courbot" , =?utf-8?q?Onur_=C3=96zkan?= , , , , , , To: "Gary Guo" From: "Danilo Krummrich" References: <20260715-rust_serdev-v14-0-b4ed5c93606f@posteo.de> <2026071747-android-overhead-c927@gregkh> <6aafea3fdb0847766787dbe5c7c7dbaad606d649.camel@posteo.de> <74213297-d3da-4637-8f31-8fecebd65f60@kernel.org> <2026071719-afflicted-eleven-1be9@gregkh> In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri Jul 17, 2026 at 2:07 PM CEST, Gary Guo wrote: > FWIW this series will also conflict quite significantly with > https://lore.kernel.org/driver-core/20260629-id_info-v2-0-56fccbe9c5ef@ga= ryguo.net/ > which is routed via driver-core tree. Yeah, but I think it should be trivial (see below)? However, routing serdev through driver-core does indeed avoid this. Thanks, Danilo diff --git a/rust/kernel/serdev.rs b/rust/kernel/serdev.rs index 0ffcef1849d2..a1161dd9f37f 100644 --- a/rust/kernel/serdev.rs +++ b/rust/kernel/serdev.rs @@ -174,7 +174,8 @@ extern "C" fn probe_callback(sdev: *mut bindings::serde= v_device) -> kernel::ffi: // // INVARIANT: `sdev` is valid for the duration of `probe_callback(= )`. let sdev =3D unsafe { &*sdev.cast::>>() }; - let info =3D ::id_info(sdev.as_ref()); + // SAFETY: `sdev` has been matched by the serial device bus via it= s device ID table. + let info =3D unsafe { ::id_info(sdev.as_r= ef()) }; from_result(|| { sdev.as_ref().set_drvdata(try_pin_init!(PrivateData:: { @@ -334,7 +335,6 @@ macro_rules! module_serdev_device_driver { /// /// kernel::of_device_table!( /// OF_TABLE, -/// MODULE_OF_TABLE, /// ::IdInfo, /// [ /// (of::DeviceId::new(c"test,device"), ()) @@ -343,7 +343,6 @@ macro_rules! module_serdev_device_driver { /// /// kernel::acpi_device_table!( /// ACPI_TABLE, -/// MODULE_ACPI_TABLE, /// ::IdInfo, /// [ /// (acpi::DeviceId::new(c"LNUXBEEF"), ()) diff --git a/samples/rust/rust_driver_serdev.rs b/samples/rust/rust_driver_= serdev.rs index a12b1412db30..51b4898cd855 100644 --- a/samples/rust/rust_driver_serdev.rs +++ b/samples/rust/rust_driver_serdev.rs @@ -20,14 +20,12 @@ struct SampleDriver { kernel::of_device_table!( OF_TABLE, - MODULE_OF_TABLE, ::IdInfo, [(of::DeviceId::new(c"test,rust_driver_serdev"), ())] ); kernel::acpi_device_table!( ACPI_TABLE, - MODULE_ACPI_TABLE, ::IdInfo, [(acpi::DeviceId::new(c"LNUXBEEF"), ())] );