From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1BE9C53219 for ; Tue, 28 Jul 2026 09:48:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3B01510E857; Tue, 28 Jul 2026 09:48:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="NW8P8R8t"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id EDCDB10E866 for ; Tue, 28 Jul 2026 09:48:32 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 9B178406C9; Tue, 28 Jul 2026 09:48:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7AB01F000E9; Tue, 28 Jul 2026 09:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785232112; bh=vpKhq3J9yvyoQprJhL3ImKybp8EYteMcnslfwlaSUSk=; h=Date:From:Subject:Cc:To:References:In-Reply-To; b=NW8P8R8tvLHxjzoN/6kOD8OOryRyD2J6X8ogsbq+ADUjEMbQnJoM+Gv7NZid4jVit 7Jscsyzb8Py+niEuUd6w+oPj5pe5ediPJDDGGBX4jIdD3lYUJkz07wp/C1hkRGXJvh hk0CC/COs4JX1DgLA/1A6s4Lg/m/BuAHO8ae0/Fm7Pyty0yVmw0cFN8MHAsGVme4rw 0apszy4D6NXD17qVXgmjNWExb9ZUop+oXesHlovXw+jnkso/sxSHCH2iTERyInw6nS B5roTNbRO1QgxNrPRWHJ9gHHWV1jm4u6FNwyU7w67ZL0142muUxuKM34PrCdslxL06 v2RHYfbd+KJNQ== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 28 Jul 2026 11:48:26 +0200 Message-Id: From: "Danilo Krummrich" Subject: Re: [PATCH v9 1/7] drm/tyr: add resources to RegistrationData Cc: "Daniel Almeida" , "Alice Ryhl" , "David Airlie" , "Simona Vetter" , "Benno Lossin" , "Gary Guo" , "Miguel Ojeda" , "Boqun Feng" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Andreas Hindborg" , "Trevor Gross" , "Tamir Duberstein" , "Alexandre Courbot" , =?utf-8?q?Onur_=C3=96zkan?= , , , , , , , , , , To: "Deborah Brouwer" References: <20260722-fw-boot-b4-v9-0-8669d2a02590@collabora.com> <20260722-fw-boot-b4-v9-1-8669d2a02590@collabora.com> In-Reply-To: <20260722-fw-boot-b4-v9-1-8669d2a02590@collabora.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu Jul 23, 2026 at 1:54 AM CEST, Deborah Brouwer wrote: > @@ -53,13 +51,17 @@ > =20 > #[pin_data(PinnedDrop)] > pub(crate) struct TyrPlatformDriverData<'bound> { > - _device: ARef, > _reg: drm::Registration<'bound, TyrDrmDriver>, > } > =20 > +/// Data owned by the DRM [`Registration`]. > +/// > +/// This data can have references tied to the parent platform device bin= ding scope > +/// and is accessible only while the DRM device is registered with users= pace. > #[pin_data] > -pub(crate) struct TyrDrmDeviceData { > - pub(crate) pdev: ARef, > +pub(crate) struct TyrDrmRegistrationData<'bound> { Please use a different lifetime name for this, 'bound should only be used f= or the bus device private data itself, as its lifetime defines this scope. May= be use 'drm instead? The same is true for a couple of other places in this series, such as Mmu<'bound>, VmAsData<'bound>, etc. Please feel free to fix up on apply or in a follow-up patch.