From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CAF8FC55182 for ; Mon, 3 Aug 2026 17:56:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 28B7710E641; Mon, 3 Aug 2026 17:56:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="YcbQOOmE"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F0A610E641 for ; Mon, 3 Aug 2026 17:56:47 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id A81E460AAE; Mon, 3 Aug 2026 17:56:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 969BF1F00A3A; Mon, 3 Aug 2026 17:56:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785779806; bh=0W2dA/tdnG6mWPGo2zM7KT0maUNZ2/vxD3OQ7HNm5g0=; h=Date:Subject:Cc:To:From:References:In-Reply-To; b=YcbQOOmEtOpQVHtYFHt/jXOGqQoQngTf+ugzZGePRvRRrYA8DOQsPqvRNLDpi/lzj jz9tFTlvR/UE2Bjl9JKWwTDydTq5SZga+Z8qVRBFNzRWbyMDFN/6lN9uz88qfXbVOS CZ9aL15nY/gzM590dE+d3fVM7iWfbUw+tO6kZbshW0d4gkLxc8zfUlevC+RNiEJlPS YAwiWrvq7LvJxBq2aAkFhj8xHmhvk4Uf5oBvYHKFYYyytz1eC4TbTgCu52KgGasT4+ L2H5s32RncX9xZrb/U2tXm9WKdItOazlEDBoJG6F4SwVGCNbY1oV2KR+IFq/0Ovy+m yDPdFyPTb288w== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 03 Aug 2026 19:56:39 +0200 Message-Id: Subject: Re: [PATCH v2 9/9] drm/debugfs: hold device reference for the lifetime of open files Cc: "Miguel Ojeda" , "Boqun Feng" , "Gary Guo" , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , "Benno Lossin" , "Andreas Hindborg" , "Alice Ryhl" , "Trevor Gross" , "Daniel Almeida" , "Tamir Duberstein" , "Alexandre Courbot" , =?utf-8?q?Onur_=C3=96zkan?= , "Greg Kroah-Hartman" , "Rafael J. Wysocki" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Alexander Viro" , "Christian Brauner" , "Jan Kara" , "Matthew Brost" , =?utf-8?q?Thomas_Hellstr=C3=B6m?= , =?utf-8?q?Ma=C3=ADra_Canal?= , "Melissa Wen" , "Wambui Karuga" , "Eric Anholt" , "Ben Gamari" , , , To: "Alvin Sun" From: "Danilo Krummrich" References: <20260731-tyr-debugfs-v2-v2-0-aea19eccb996@linux.dev> <20260731-tyr-debugfs-v2-v2-9-aea19eccb996@linux.dev> In-Reply-To: <20260731-tyr-debugfs-v2-v2-9-aea19eccb996@linux.dev> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu Jul 30, 2026 at 7:05 PM CEST, Alvin Sun wrote: > Hold a device reference (via drm_dev_get/put) across the lifetime of open > debugfs files. Prevents use-after-free when a device is unregistered whil= e > a debugfs file remains open. Both drm_debugfs_open (legacy info_list) > and drm_debugfs_entry_open (drm_debugfs_add_file) paths are covered. > > Fixes: 1c9cacbea8805 ("drm/debugfs: create device-centered debugfs functi= ons") > Fixes: 28a62277e06f9 ("drm: Convert proc files to seq_file and introduce = debugfs") > > Signed-off-by: Alvin Sun > --- > drivers/gpu/drm/drm_debugfs.c | 42 +++++++++++++++++++++++++++++++++++++= +---- > 1 file changed, 38 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.= c > index 38cf6ce387cc8..5262a708f1602 100644 > --- a/drivers/gpu/drm/drm_debugfs.c > +++ b/drivers/gpu/drm/drm_debugfs.c > @@ -159,11 +159,28 @@ static const struct drm_debugfs_info drm_debugfs_li= st[] =3D { > static int drm_debugfs_open(struct inode *inode, struct file *file) > { > struct drm_info_node *node =3D inode->i_private; > + struct drm_device *dev =3D node->minor->dev; > + int ret; > =20 > if (!device_is_registered(node->minor->kdev)) > return -ENODEV; > =20 > - return single_open(file, node->info_ent->show, node); > + drm_dev_get(dev); > + > + ret =3D single_open(file, node->info_ent->show, node); > + if (ret) > + drm_dev_put(dev); > + > + return ret; > +} > + > +static int drm_debugfs_release(struct inode *inode, struct file *file) > +{ > + struct drm_info_node *node =3D > + ((struct seq_file *)file->private_data)->private; > + > + drm_dev_put(node->minor->dev); > + return single_release(inode, file); > } This isn't needed; in drm_dev_unregister() we call debugfs_remove_recursive= (), which already waits for all in-flight file operations. The DRM device itsel= f is guaranteed to be valid as long as it is registered.