From: "Eliot Courtney" <ecourtney@nvidia.com>
To: "Gary Guo" <gary@garyguo.net>,
"Eliot Courtney" <ecourtney@nvidia.com>,
"Alexandre Courbot" <acourbot@nvidia.com>,
"Yury Norov" <yury.norov@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun@kernel.org>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Tamir Duberstein" <tamird@kernel.org>,
"Onur Özkan" <work@onurozkan.dev>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: "John Hubbard" <jhubbard@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>, <rust-for-linux@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <nova-gpu@lists.linux.dev>,
<dri-devel@lists.freedesktop.org>,
"dri-devel" <dri-devel-bounces@lists.freedesktop.org>
Subject: Re: [PATCH v2 3/3] gpu: nova-core: use cv! for constant casts
Date: Wed, 02 Sep 2026 17:35:04 +0900 [thread overview]
Message-ID: <DL4OY7H72UXD.2FWYTKH2SSZ5I@nvidia.com> (raw)
In-Reply-To: <DL3YIG34IP1Y.1G32YQU0JYUTE@garyguo.net>
On Tue Sep 1, 2026 at 8:52 PM JST, Gary Guo wrote:
> On Tue Sep 1, 2026 at 6:06 AM BST, Eliot Courtney wrote:
>> The new `cv!` macro allows safe casting of constant expressions in a
>> const context. Update code in nova-core to use it.
>>
>> Signed-off-by: Eliot Courtney <ecourtney@nvidia.com>
>
> I like the ergnomics improvement :)
>
> Reviewed-by: Gary Guo <gary@garyguo.net>
>
>> ---
>> drivers/gpu/nova-core/falcon.rs | 9 ++--
>> drivers/gpu/nova-core/fb/hal/gb100.rs | 4 +-
>> drivers/gpu/nova-core/firmware/fwsec/bootloader.rs | 7 +--
>> drivers/gpu/nova-core/fsp.rs | 3 +-
>> drivers/gpu/nova-core/gsp/cmdq.rs | 6 +--
>> drivers/gpu/nova-core/gsp/fw.rs | 38 +++++++--------
>> drivers/gpu/nova-core/gsp/fw/commands.rs | 2 +-
>> drivers/gpu/nova-core/num.rs | 55 +---------------------
>> 8 files changed, 28 insertions(+), 96 deletions(-)
Thanks for the reviews!
prev parent reply other threads:[~2026-09-02 8:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 5:06 [PATCH v2 0/3] rust: introduce cv! macro for safe const conversions of integer-like types Eliot Courtney
2026-09-01 5:06 ` [PATCH v2 1/3] rust: num: add cv! macro to create values from constant expressions Eliot Courtney
2026-09-01 11:50 ` Gary Guo
2026-09-01 20:18 ` John Hubbard
2026-09-01 23:19 ` Miguel Ojeda
2026-09-01 5:06 ` [PATCH v2 2/3] rust: prelude: add `num::cv` Eliot Courtney
2026-09-01 11:50 ` Gary Guo
2026-09-01 5:06 ` [PATCH v2 3/3] gpu: nova-core: use cv! for constant casts Eliot Courtney
2026-09-01 11:52 ` Gary Guo
2026-09-02 8:35 ` Eliot Courtney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DL4OY7H72UXD.2FWYTKH2SSZ5I@nvidia.com \
--to=ecourtney@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel-bounces@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
--cc=work@onurozkan.dev \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox