* [PATCH] drm/i915/backlight: Honor VESA eDP backlight luminance control capability
@ 2025-08-23 12:16 Aaron Ma
2025-08-23 12:47 ` Kandpal, Suraj
0 siblings, 1 reply; 3+ messages in thread
From: Aaron Ma @ 2025-08-23 12:16 UTC (permalink / raw)
To: jani.nikula, rodrigo.vivi, joonas.lahtinen, tursulin, airlied,
simona, suraj.kandpal, intel-gfx, intel-xe, dri-devel,
linux-kernel
The VESA AUX backlight failed to be enabled becaused luminance_set is
false always.
Fix it by using luminance support control capabitliy.
Fixes: e13af5166a359 ("drm/i915/backlight: Use drm helper to initialize edp backlight")
Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
---
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index 41228478b21c7..0a3a3f6a5f9d8 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -546,7 +546,7 @@ static int intel_dp_aux_vesa_setup_backlight(struct intel_connector *connector,
luminance_range->max_luminance,
panel->vbt.backlight.pwm_freq_hz,
intel_dp->edp_dpcd, ¤t_level, ¤t_mode,
- false);
+ panel->backlight.edp.vesa.luminance_control_support);
if (ret < 0)
return ret;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] drm/i915/backlight: Honor VESA eDP backlight luminance control capability
2025-08-23 12:16 [PATCH] drm/i915/backlight: Honor VESA eDP backlight luminance control capability Aaron Ma
@ 2025-08-23 12:47 ` Kandpal, Suraj
2025-08-29 4:06 ` Kandpal, Suraj
0 siblings, 1 reply; 3+ messages in thread
From: Kandpal, Suraj @ 2025-08-23 12:47 UTC (permalink / raw)
To: Aaron, Ma, jani.nikula@linux.intel.com, Vivi, Rodrigo,
joonas.lahtinen@linux.intel.com, tursulin@ursulin.net,
airlied@gmail.com, simona@ffwll.ch,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
> Subject: [PATCH] drm/i915/backlight: Honor VESA eDP backlight luminance
> control capability
>
> The VESA AUX backlight failed to be enabled becaused luminance_set is false
> always.
> Fix it by using luminance support control capabitliy.
>
> Fixes: e13af5166a359 ("drm/i915/backlight: Use drm helper to initialize edp
> backlight")
> Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> index 41228478b21c7..0a3a3f6a5f9d8 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> @@ -546,7 +546,7 @@ static int intel_dp_aux_vesa_setup_backlight(struct
> intel_connector *connector,
> luminance_range->max_luminance,
> panel->vbt.backlight.pwm_freq_hz,
> intel_dp->edp_dpcd, ¤t_level,
> ¤t_mode,
> - false);
> + panel-
> >backlight.edp.vesa.luminance_control_support);
> if (ret < 0)
> return ret;
>
> --
> 2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] drm/i915/backlight: Honor VESA eDP backlight luminance control capability
2025-08-23 12:47 ` Kandpal, Suraj
@ 2025-08-29 4:06 ` Kandpal, Suraj
0 siblings, 0 replies; 3+ messages in thread
From: Kandpal, Suraj @ 2025-08-29 4:06 UTC (permalink / raw)
To: Aaron, Ma, jani.nikula@linux.intel.com, Vivi, Rodrigo,
joonas.lahtinen@linux.intel.com, tursulin@ursulin.net,
airlied@gmail.com, simona@ffwll.ch,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Nikula, Jani
> Subject: RE: [PATCH] drm/i915/backlight: Honor VESA eDP backlight luminance
> control capability
>
> > Subject: [PATCH] drm/i915/backlight: Honor VESA eDP backlight
> > luminance control capability
> >
> > The VESA AUX backlight failed to be enabled becaused luminance_set is
> > false always.
Fix the typo on 'because' here. Also fix the grammar before merging this
to something like "AUX backlight fails to enable because ..."
On an unrelated note @Nikula, Jani the commits that this patch sits on exists in
Drm-misc-next but not drm-intel-next. These said commits were merged I think a month or two back.
Now do we proceed merging these in drm-misc-next or get a pull of them in drm-intel-next
Regards,
Suraj Kandpal
> > Fix it by using luminance support control capabitliy.
> >
> > Fixes: e13af5166a359 ("drm/i915/backlight: Use drm helper to
> > initialize edp
> > backlight")
> > Signed-off-by: Aaron Ma <aaron.ma@canonical.com>
>
> LGTM,
> Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> > b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> > index 41228478b21c7..0a3a3f6a5f9d8 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
> > @@ -546,7 +546,7 @@ static int
> > intel_dp_aux_vesa_setup_backlight(struct
> > intel_connector *connector,
> > luminance_range->max_luminance,
> > panel->vbt.backlight.pwm_freq_hz,
> > intel_dp->edp_dpcd, ¤t_level,
> ¤t_mode,
> > - false);
> > + panel-
> > >backlight.edp.vesa.luminance_control_support);
> > if (ret < 0)
> > return ret;
> >
> > --
> > 2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-29 4:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-23 12:16 [PATCH] drm/i915/backlight: Honor VESA eDP backlight luminance control capability Aaron Ma
2025-08-23 12:47 ` Kandpal, Suraj
2025-08-29 4:06 ` Kandpal, Suraj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).