From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2025A606A320 for ; Tue, 20 Oct 2026 11:24:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=vCuf/qLx Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 709A510EB9D; Tue, 20 Oct 2026 11:24:50 +0000 (UTC) Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) by gabe.freedesktop.org (Postfix) with ESMTPS id 38F0910EB9D for ; Tue, 20 Oct 2026 11:24:39 +0000 (UTC) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 6190AC62200; Tue, 20 Oct 2026 11:25:36 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id DA5EC60393; Tue, 20 Oct 2026 11:24:37 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C9EDE10328D1B; Tue, 20 Oct 2026 13:24:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1792495472; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=lWY2XuNPbUYtQZXSjdjg05LI8FaRFZGhfx8rJVDmx1o=; b=vCuf/qLxEpfmHzgv2ykmlS8R6iUa8Ff96US10R5POYi23BQM9SGnKWsqTUTMi4ilvXrXf1 DlMFWhYkMHza9Z+4Ing1hsE6iYTZitXm5bLcMxeF3U9V1iGzziu8Mg6df+hMoznLEkE3zM oPje2hcVZ/jjA5rp5s1vOH/5Wqj36RZif5HuL3eSsfC8Iw1YUSQSzLzTV2uijf2FGETnT/ eoyFOpd7Txn0LjQtqqHHE6RIeiWUiXXQhU+0u7JKamgezGmi8lIsRMzxg3FFH/xNlZTy3l VV1AJ/ny9HAteCrKoqzvYVdY/lK5ASTG1/P6zBQH+REss7kv/PHao6MXBk+5OA== X-Archived-By: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 20 Oct 2026 13:24:24 +0200 Message-Id: Cc: , , "Jessica Zhang" , "Purism Kernel Team" , "Ondrej Jirman" , "Janne Grunau" , To: "Osama Abdelkader" , "Luca Ceresoli" , "Neil Armstrong" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "David Airlie" , "Simona Vetter" , "Joel Selvaraj" , "Icenowy Zheng" , "Jagan Teki" , "Sumit Semwal" , "Casey Connolly" , "Michael Tretter" , =?utf-8?q?Guido_G=C3=BCnther?= , "Sasha Finkelstein" , "Michael Trimarchi" From: "Luca Ceresoli" Subject: Re: [PATCH v7 3/3] drm/panel: Use managed helpers in assorted panels X-Mailer: aerc 0.22.0 References: In-Reply-To: X-Last-TLS-Session-Version: TLSv1.3 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "dri-devel" X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Mon Sep 21, 2026 at 3:17 PM CEST, Osama Abdelkader wrote: > Use the managed MIPI DSI attach and panel add helpers in assorted > panel drivers and drop the corresponding manual detach and panel remove > calls from remove paths. > > Suggested-by: Luca Ceresoli > Signed-off-by: Osama Abdelkader ... > --- a/drivers/gpu/drm/panel/panel-ebbg-ft8719.c > +++ b/drivers/gpu/drm/panel/panel-ebbg-ft8719.c > @@ -202,30 +202,19 @@ static int ebbg_ft8719_probe(struct mipi_dsi_device= *dsi) > if (ret) > return dev_err_probe(dev, ret, "Failed to get backlight\n"); > > - drm_panel_add(&ctx->panel); > + ret =3D devm_drm_panel_add(dev, &ctx->panel); > + if (ret) > + return ret; > > - ret =3D mipi_dsi_attach(dsi); > + ret =3D devm_mipi_dsi_attach(&dsi->dev, dsi); > if (ret < 0) { > dev_err(dev, "Failed to attach to DSI host: %d\n", ret); > - drm_panel_remove(&ctx->panel); > return ret; > } As for patch 2, this could be even simpler by using dev_err_probe(). Same for other drivers in this patch. > --- a/drivers/gpu/drm/panel/panel-sitronix-st7701.c > +++ b/drivers/gpu/drm/panel/panel-sitronix-st7701.c > @@ -1263,7 +1263,6 @@ static void st7701_cleanup(void *data) > { > struct st7701 *st7701 =3D (struct st7701 *)data; > > - drm_panel_remove(&st7701->panel); > drm_panel_disable(&st7701->panel); > drm_panel_unprepare(&st7701->panel); > } The last two calls here appear inappropriate IMO. However it's not an issue with your patch. Reviewed-by: Luca Ceresoli Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com