From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King Subject: [PATCH v3 2/7] drm/i2c: tda998x: fix error cleanup paths Date: Mon, 09 Apr 2018 13:16:17 +0100 Message-ID: References: <20180409121529.GA31403@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by gabe.freedesktop.org (Postfix) with ESMTPS id C9C1C6E1FB for ; Mon, 9 Apr 2018 12:22:08 +0000 (UTC) In-Reply-To: <20180409121529.GA31403@n2100.armlinux.org.uk> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans Verkuil Cc: David Airlie , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SWYgdGRhOTk4eF9nZXRfYXVkaW9fcG9ydHMoKSBmYWlscywgYW5kIHdlIHJlcXVlc3RlZCB0aGUg aW50ZXJydXB0LCB3ZQpmYWlsIHRvIGZyZWUgdGhlIGludGVycnVwdCBiZWZvcmUgcmV0dXJuaW5n IGZhaWx1cmUuICBSZXdvcmsgdGhlIGZhaWx1cmUKY2xlYW51cCBjb2RlIGFuZCBleGl0IHBhdGhz IHNvIHRoYXQgd2UgYWx3YXlzIGNsZWFuIHVwIHByb3Blcmx5IGFmdGVyIGFuCmVycm9yLCBhbmQg YWx3YXlzIHByb3BhZ2F0ZSB0aGUgZXJyb3IgY29kZS4KCkFja2VkLWJ5OiBIYW5zIFZlcmt1aWwg PGhhbnMudmVya3VpbEBjaXNjby5jb20+ClNpZ25lZC1vZmYtYnk6IFJ1c3NlbGwgS2luZyA8cm1r K2tlcm5lbEBhcm1saW51eC5vcmcudWs+Ci0tLQogZHJpdmVycy9ncHUvZHJtL2kyYy90ZGE5OTh4 X2Rydi5jIHwgMzEgKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5n ZWQsIDE4IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pMmMvdGRhOTk4eF9kcnYuYyBiL2RyaXZlcnMvZ3B1L2RybS9pMmMvdGRhOTk4 eF9kcnYuYwppbmRleCA4MzQwNzE1OWU5NTcuLjJhOTk5MzBmMWJkYSAxMDA2NDQKLS0tIGEvZHJp dmVycy9ncHUvZHJtL2kyYy90ZGE5OTh4X2Rydi5jCisrKyBiL2RyaXZlcnMvZ3B1L2RybS9pMmMv dGRhOTk4eF9kcnYuYwpAQCAtMTUwMSwxMCArMTUwMSwxNSBAQCBzdGF0aWMgaW50IHRkYTk5OHhf Y3JlYXRlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQsIHN0cnVjdCB0ZGE5OTh4X3ByaXYgKnBy aXYpCiAKIAkvKiByZWFkIHZlcnNpb246ICovCiAJcmV2X2xvID0gcmVnX3JlYWQocHJpdiwgUkVH X1ZFUlNJT05fTFNCKTsKKwlpZiAocmV2X2xvIDwgMCkgeworCQlkZXZfZXJyKCZjbGllbnQtPmRl diwgImZhaWxlZCB0byByZWFkIHZlcnNpb246ICVkXG4iLCByZXZfbG8pOworCQlyZXR1cm4gcmV2 X2xvOworCX0KKwogCXJldl9oaSA9IHJlZ19yZWFkKHByaXYsIFJFR19WRVJTSU9OX01TQik7Ci0J aWYgKHJldl9sbyA8IDAgfHwgcmV2X2hpIDwgMCkgewotCQlyZXQgPSByZXZfbG8gPCAwID8gcmV2 X2xvIDogcmV2X2hpOwotCQlnb3RvIGZhaWw7CisJaWYgKHJldl9oaSA8IDApIHsKKwkJZGV2X2Vy cigmY2xpZW50LT5kZXYsICJmYWlsZWQgdG8gcmVhZCB2ZXJzaW9uOiAlZFxuIiwgcmV2X2hpKTsK KwkJcmV0dXJuIHJldl9oaTsKIAl9CiAKIAlwcml2LT5yZXYgPSByZXZfbG8gfCByZXZfaGkgPDwg ODsKQEAgLTE1MjgsNyArMTUzMyw3IEBAIHN0YXRpYyBpbnQgdGRhOTk4eF9jcmVhdGUoc3RydWN0 IGkyY19jbGllbnQgKmNsaWVudCwgc3RydWN0IHRkYTk5OHhfcHJpdiAqcHJpdikKIAlkZWZhdWx0 OgogCQlkZXZfZXJyKCZjbGllbnQtPmRldiwgImZvdW5kIHVuc3VwcG9ydGVkIGRldmljZTogJTA0 eFxuIiwKIAkJCXByaXYtPnJldik7Ci0JCWdvdG8gZmFpbDsKKwkJcmV0dXJuIC1FTlhJTzsKIAl9 CiAKIAkvKiBhZnRlciByZXNldCwgZW5hYmxlIEREQzogKi8KQEAgLTE1NjYsNyArMTU3MSw3IEBA IHN0YXRpYyBpbnQgdGRhOTk4eF9jcmVhdGUoc3RydWN0IGkyY19jbGllbnQgKmNsaWVudCwgc3Ry dWN0IHRkYTk5OHhfcHJpdiAqcHJpdikKIAkJCWRldl9lcnIoJmNsaWVudC0+ZGV2LAogCQkJCSJm YWlsZWQgdG8gcmVxdWVzdCBJUlEjJXU6ICVkXG4iLAogCQkJCWNsaWVudC0+aXJxLCByZXQpOwot CQkJZ290byBmYWlsOworCQkJZ290byBlcnJfaXJxOwogCQl9CiAKIAkJLyogZW5hYmxlIEhQRCBp cnEgKi8KQEAgLTE1ODksMTkgKzE1OTQsMTkgQEAgc3RhdGljIGludCB0ZGE5OTh4X2NyZWF0ZShz dHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50LCBzdHJ1Y3QgdGRhOTk4eF9wcml2ICpwcml2KQogCiAJ cmV0ID0gdGRhOTk4eF9nZXRfYXVkaW9fcG9ydHMocHJpdiwgbnApOwogCWlmIChyZXQpCi0JCWdv dG8gZmFpbDsKKwkJZ290byBlcnJfYXVkaW87CiAKIAlpZiAocHJpdi0+YXVkaW9fcG9ydFswXS5m b3JtYXQgIT0gQUZNVF9VTlVTRUQpCiAJCXRkYTk5OHhfYXVkaW9fY29kZWNfaW5pdChwcml2LCAm Y2xpZW50LT5kZXYpOwogCiAJcmV0dXJuIDA7Ci1mYWlsOgotCS8qIGlmIGVuY29kZXJfaW5pdCBm YWlscywgdGhlIGVuY29kZXIgc2xhdmUgaXMgbmV2ZXIgcmVnaXN0ZXJlZCwKLQkgKiBzbyBjbGVh bnVwIGhlcmU6Ci0JICovCi0JaWYgKHByaXYtPmNlYykKLQkJaTJjX3VucmVnaXN0ZXJfZGV2aWNl KHByaXYtPmNlYyk7Ci0JcmV0dXJuIC1FTlhJTzsKKworZXJyX2F1ZGlvOgorCWlmIChjbGllbnQt PmlycSkKKwkJZnJlZV9pcnEoY2xpZW50LT5pcnEsIHByaXYpOworZXJyX2lycToKKwlpMmNfdW5y ZWdpc3Rlcl9kZXZpY2UocHJpdi0+Y2VjKTsKKwlyZXR1cm4gcmV0OwogfQogCiBzdGF0aWMgdm9p ZCB0ZGE5OTh4X2VuY29kZXJfcHJlcGFyZShzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIpCi0t IAoyLjcuNAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==