From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9925C433FE for ; Mon, 15 Nov 2021 19:11:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BBD36128E for ; Mon, 15 Nov 2021 19:11:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7BBD36128E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=crapouillou.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 870C76E570; Mon, 15 Nov 2021 19:11:54 +0000 (UTC) Received: from aposti.net (aposti.net [89.234.176.197]) by gabe.freedesktop.org (Postfix) with ESMTPS id F157E6E570 for ; Mon, 15 Nov 2021 19:11:53 +0000 (UTC) Date: Mon, 15 Nov 2021 19:11:39 +0000 From: Paul Cercueil Subject: Re: [PATCH v6 5/8] MIPS: DTS: jz4780: Account for Synopsys HDMI driver and LCD controllers To: "H. Nikolaus Schaller" Message-Id: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Paul Boddie , Geert Uytterhoeven , Neil Armstrong , David Airlie , dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Laurent Pinchart , Miquel Raynal , Sam Ravnborg , Jernej Skrabec , devicetree@vger.kernel.org, Kees Cook , Jonas Karlman , Mark Brown , Maxime Ripard , letux-kernel@openphoenux.org, Ezequiel Garcia , Thomas Bogendoerfer , Liam Girdwood , Robert Foss , linux-kernel@vger.kernel.org, Rob Herring , "Eric W. Biederman" , Hans Verkuil Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Nikolaus, Le mer., nov. 10 2021 at 20:43:30 +0100, H. Nikolaus Schaller=20 a =E9crit : > From: Paul Boddie >=20 > A specialisation of the generic Synopsys HDMI driver is employed for=20 > JZ4780 > HDMI support. This requires a new driver, plus device tree and=20 > configuration > modifications. >=20 > Signed-off-by: Paul Boddie > Signed-off-by: H. Nikolaus Schaller > --- > arch/mips/boot/dts/ingenic/jz4780.dtsi | 40=20 > ++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) >=20 > diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi=20 > b/arch/mips/boot/dts/ingenic/jz4780.dtsi > index 9e34f433b9b58..98cc3360bbbb9 100644 > --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi > +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi > @@ -424,6 +424,46 @@ i2c4: i2c@10054000 { > status =3D "disabled"; > }; >=20 > + hdmi: hdmi@10180000 { > + compatible =3D "ingenic,jz4780-dw-hdmi"; > + reg =3D <0x10180000 0x8000>; > + reg-io-width =3D <4>; > + > + clocks =3D <&cgu JZ4780_CLK_AHB0>, <&cgu JZ4780_CLK_HDMI>; > + clock-names =3D "iahb", "isfr"; > + > + interrupt-parent =3D <&intc>; > + interrupts =3D <3>; > + > + status =3D "disabled"; > + }; > + > + lcdc0: lcdc0@13050000 { > + compatible =3D "ingenic,jz4780-lcd"; > + reg =3D <0x13050000 0x1800>; > + > + clocks =3D <&cgu JZ4780_CLK_TVE>, <&cgu JZ4780_CLK_LCD0PIXCLK>; > + clock-names =3D "lcd", "lcd_pclk"; > + > + interrupt-parent =3D <&intc>; > + interrupts =3D <31>; > + > + status =3D "disabled"; > + }; > + > + lcdc1: lcdc1@130a0000 { > + compatible =3D "ingenic,jz4780-lcd"; > + reg =3D <0x130a0000 0x1800>; > + > + clocks =3D <&cgu JZ4780_CLK_TVE>, <&cgu JZ4780_CLK_LCD1PIXCLK>; > + clock-names =3D "lcd", "lcd_pclk"; > + > + interrupt-parent =3D <&intc>; > + interrupts =3D <31>; You have the two LCD controllers wired to the same interrupt, that=20 can't be right. From what I can read in the PM the LCD1 IRQ is number 23. Cheers, -Paul > + > + status =3D "disabled"; > + }; > + > nemc: nemc@13410000 { > compatible =3D "ingenic,jz4780-nemc", "simple-mfd"; > reg =3D <0x13410000 0x10000>; > -- > 2.33.0 >=20