From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48AE3C433E0 for ; Mon, 21 Dec 2020 22:09:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D34BA22A83 for ; Mon, 21 Dec 2020 22:09:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D34BA22A83 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 177546E5CE; Mon, 21 Dec 2020 22:09:05 +0000 (UTC) Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 72CE06E5CE for ; Mon, 21 Dec 2020 22:09:03 +0000 (UTC) Received: by mail-wm1-x32b.google.com with SMTP id k10so302646wmi.3 for ; Mon, 21 Dec 2020 14:09:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=Kv6+mQ/2PR9Y/KxXUnGcTVCVLw1XND8pVr3hmrooxtw=; b=bXURP2LmkZg8fIIAV3AQ1ix/+TrCccX+pgpMEdTDOtAyRrAoIcaz7vjFYIfFF5vqtB fScpfzoozZ2OHDV1HEy4SG7y7bGok7OOey/N6hatW11QsOS4gIUGMin4BTbTqaQK4C4f hA3seveuaB4PBNmzqb/7sgGfcLxMWJtTDlGUI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=Kv6+mQ/2PR9Y/KxXUnGcTVCVLw1XND8pVr3hmrooxtw=; b=SYieTma3gacMkItxP3MTMMeT9HSmp04EnOMtAFSTBGhNFK/DjY2V/25xgrO1CFRP9r 5d70IUBymz/3vlYDlNXi6IbAnvmYIdwWvIPll1IAoAJe26sMG0JwtDAF2PgrA+9M9aNt sgvA4LkWWySVwlZMQ9xeRtI44ya70M2nNrN57rQmqAAjlZawRxB1J0IZHoJiPeaOuu9k yHZbH2RuFLErNZCEtSiWe6MfaTsaF65O5rLsnn5pEFMlNKiG9XJBfySRDygkkVMtfHwG piLCAMxundm2AzkT14njeC93tqaZZQJjeAoTWFINHzeSLXaQzw2U45wlSGITi1SXToLq 4wpQ== X-Gm-Message-State: AOAM530PWE027FEZptTJvfVcPZ2Z67LoOfuceIRof0YVkCk5arQbFGnQ lEiEeOFRnw9b7jbNv+2N1bFhGg== X-Google-Smtp-Source: ABdhPJw1cpWZY8Yn4zYH0KalUyHjvqfJLlKsUh5A1txhbBjhxrVKP9ag6vGkqqnOY7+6wx1+B8t0Ag== X-Received: by 2002:a7b:cd90:: with SMTP id y16mr18996235wmj.115.1608588542090; Mon, 21 Dec 2020 14:09:02 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id m5sm18056514wrz.18.2020.12.21.14.09.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Dec 2020 14:09:01 -0800 (PST) Date: Mon, 21 Dec 2020 23:08:59 +0100 From: Daniel Vetter To: John Stultz Subject: Re: [RFC][PATCH 2/3] dma-buf: system_heap: Add pagepool support to system heap Message-ID: Mail-Followup-To: John Stultz , lkml , Sandeep Patil , dri-devel , Ezequiel Garcia , Robin Murphy , James Jones , Liam Mark , Laura Abbott , Chris Goldsworthy , Hridya Valsaraju , =?iso-8859-1?Q?=D8rjan?= Eide , linux-media , Suren Baghdasaryan , Daniel Mentz References: <20201217230612.32397-1-john.stultz@linaro.org> <20201217230612.32397-2-john.stultz@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sandeep Patil , Robin Murphy , James Jones , Daniel Mentz , lkml , dri-devel , Suren Baghdasaryan , Liam Mark , Chris Goldsworthy , Hridya Valsaraju , =?iso-8859-1?Q?=D8rjan?= Eide , linux-media , Ezequiel Garcia , Laura Abbott Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Dec 18, 2020 at 05:16:56PM -0800, John Stultz wrote: > On Fri, Dec 18, 2020 at 6:36 AM Daniel Vetter wrote: > > On Thu, Dec 17, 2020 at 11:06:11PM +0000, John Stultz wrote: > > > Reuse/abuse the pagepool code from the network code to speed > > > up allocation performance. > > > > > > This is similar to the ION pagepool usage, but tries to > > > utilize generic code instead of a custom implementation. > > > > We also have one of these in ttm. I think we should have at most one of > > these for the gpu ecosystem overall, maybe as a helper that can be plugged > > into all the places. > > > > Or I'm kinda missing something, which could be since I only glanced at > > yours for a bit. But it's also called page pool for buffer allocations, > > and I don't think there's that many ways to implement that really :-) > > Yea, when I was looking around the ttm one didn't seem quite as > generic as the networking one, which more easily fit in here. Oops, I didn't look that closely and didn't realize you're reusing the one from net/core/. > The main benefit for the system heap is not so much the pool itself > (the normal page allocator is pretty good), as it being able to defer > the free and zero the pages in a background thread, so the pool is > effectively filled with pre-zeroed pages. > > But I'll take another look at the ttm implementation and see if it can > be re-used or the shared code refactored and pulled out somehow. I think moving the page_pool from net into lib and using it in ttm might also be an option. Lack of shrinker in the networking one might be a bit a problem. Also I guess the real fun will start if you pre-flush pages (after zeroing) or use write-combined mode (which tends to be a real pain to allocate). So for those I think we likely need more than just reusing the one net/core has already. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel