From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4B5AC433FE for ; Fri, 4 Dec 2020 15:55:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63C0722B30 for ; Fri, 4 Dec 2020 15:55:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 63C0722B30 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 737A46E19C; Fri, 4 Dec 2020 15:55:01 +0000 (UTC) Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by gabe.freedesktop.org (Postfix) with ESMTPS id E5D926E199 for ; Fri, 4 Dec 2020 15:54:59 +0000 (UTC) Received: by mail-ed1-x543.google.com with SMTP id cw27so6329171edb.5 for ; Fri, 04 Dec 2020 07:54:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=AHQHq1xL8SJ5NWI2Z081/APQVBFOAsAFbhSvIy9O+O4=; b=bWCk4mSKVJwDh1g8B2dSMt8iEtSNfurQhLS7058Y6rhgMTutxo2/L7yA6tbhbQbQwf mT45Zd/pZM13Z3m+YIPCA530+4H8E8QbWu+zrgt9VUx40b7q0I0QX1u6YvVPPEUZAhfA beoKBCPizS04KXqb0MgUrTXdPv026hwBQXp+3tegYL1mb3ACg3RmVlT5TdOL740b+4qJ k1/8wMNgnQ5eMut3nZa+gF3ypYBPCrdYutzKRFUFv1k4VQ2RfIlIKIpu8ngVIdRCzpmd 2wOuModdUv7bn4uCf0qCRd3akvgM+hm1Hpm/zvFIqueaVTRck8ott//pDPf6ys6/+H18 MqxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=AHQHq1xL8SJ5NWI2Z081/APQVBFOAsAFbhSvIy9O+O4=; b=MnaZ/oq3eWvVpnl8MxbkvNL3yTVJkfO4G3ZxHYc82sc241/IHGYHgATjjvx7BFjwTP gRPHMOQVbktpFliQljG2RGz7vfuhLYz88gvi1lfS8y9uwWCk042ZrmpB0WCw91AXfe8M KGJ+uMhELBoTGZvizxH/IMbpBDNXZFuNdyOCz0hnSsqcYKjDQyrTUSP3u2u6J0IFAmWQ xi6FO9/aQ1KDgRyGpsXWmXlqCH7rUIOsMNHyb5rQ/cJZjw+Cie5Eg+UBIUnTPGyK1YF3 cVqbK6Fuh9CQsg0eVX6kN0KDV9dz3vIaIkLEbsAtjRDrrafiZPqy4nRBX/c0eY1ktRCs MKNg== X-Gm-Message-State: AOAM530j8dJ02PPg2xdrNN8IWhsqLoyoISSEKjgWfuXfuwKDys9AO/94 QhcB/AGc6cUiOsvISEB+wiA= X-Google-Smtp-Source: ABdhPJwIwYpBPdNvrAZSaORpA0OUP9tWoQ6MOGfXKFpG3ZQf4WOv1c6QoxKrcDfcYlTrC8WuNBpq9A== X-Received: by 2002:a50:fc9a:: with SMTP id f26mr7996946edq.255.1607097298616; Fri, 04 Dec 2020 07:54:58 -0800 (PST) Received: from localhost ([62.96.65.119]) by smtp.gmail.com with ESMTPSA id x16sm3330153ejo.104.2020.12.04.07.54.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 07:54:57 -0800 (PST) Date: Fri, 4 Dec 2020 16:54:55 +0100 From: Thierry Reding To: Dmitry Osipenko , Krzysztof Kozlowski Subject: Re: [PATCH v10 17/19] ARM: tegra: Add EMC OPP properties to Tegra20 device-trees Message-ID: References: <20201123002723.28463-1-digetx@gmail.com> <20201123002723.28463-18-digetx@gmail.com> <60657f5e-bd30-094e-f8df-6ba69e0d6a3e@nvidia.com> <1ed05baf-3a01-3a2b-cd79-98b356c846cf@gmail.com> MIME-Version: 1.0 In-Reply-To: <1ed05baf-3a01-3a2b-cd79-98b356c846cf@gmail.com> User-Agent: Mutt/2.0.2 (d9268908) (2020-11-20) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mikko Perttunen , Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Peter De Schrijver , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Georgi Djakov , Chanwoo Choi , Kyungmin Park , Rob Herring , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Jon Hunter , Michael Turquette Content-Type: multipart/mixed; boundary="===============0398311842==" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --===============0398311842== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KMNCFJXxkXYagfyn" Content-Disposition: inline --KMNCFJXxkXYagfyn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 01, 2020 at 01:57:44AM +0300, Dmitry Osipenko wrote: > 01.12.2020 00:17, Jon Hunter =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > Hi Dmitry, > >=20 > > On 23/11/2020 00:27, Dmitry Osipenko wrote: > >> Add EMC OPP DVFS tables and update board device-trees by removing > >> unsupported OPPs. > >> > >> Signed-off-by: Dmitry Osipenko > > This change is generating the following warning on Tegra20 Ventana > > and prevents the EMC from probing ... > >=20 > > [ 2.485711] tegra20-emc 7000f400.memory-controller: device-tree does= n't have memory timings > > [ 2.499386] tegra20-emc 7000f400.memory-controller: 32bit DRAM bus > > [ 2.505810] ------------[ cut here ]------------ > > [ 2.510511] WARNING: CPU: 0 PID: 1 at /local/workdir/tegra/mlt-linux= _next/kernel/drivers/opp/of.c:875 _of_add_opp_table_v2+0x598/0x61c > > [ 2.529746] Modules linked in: > > [ 2.540140] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.10.0-rc5-nex= t-20201130 #1 > > [ 2.554606] Hardware name: NVIDIA Tegra SoC (Flattened Device Tree) > > [ 2.560892] [] (unwind_backtrace) from [] (show_= stack+0x10/0x14) > > [ 2.568640] [] (show_stack) from [] (dump_stack+= 0xc8/0xdc) > > [ 2.575866] [] (dump_stack) from [] (__warn+0x10= 4/0x108) > > [ 2.582912] [] (__warn) from [] (warn_slowpath_f= mt+0xb0/0xb8) > > [ 2.590397] [] (warn_slowpath_fmt) from [] (_of_= add_opp_table_v2+0x598/0x61c) > > [ 2.599269] [] (_of_add_opp_table_v2) from [] (d= ev_pm_opp_of_add_table+0x3c/0x1a0) > > [ 2.608582] [] (dev_pm_opp_of_add_table) from []= (tegra_emc_probe+0x478/0x940) > > [ 2.617548] [] (tegra_emc_probe) from [] (platfo= rm_drv_probe+0x48/0x98) > > [ 2.625899] [] (platform_drv_probe) from [] (rea= lly_probe+0x218/0x3b8) > > [ 2.634162] [] (really_probe) from [] (driver_pr= obe_device+0x5c/0xb4) > > [ 2.642338] [] (driver_probe_device) from [] (de= vice_driver_attach+0x58/0x60) > > [ 2.651208] [] (device_driver_attach) from [] (_= _driver_attach+0x80/0xbc) > > [ 2.659730] [] (__driver_attach) from [] (bus_fo= r_each_dev+0x74/0xb4) > > [ 2.667905] [] (bus_for_each_dev) from [] (bus_a= dd_driver+0x164/0x1e8) > > [ 2.676168] [] (bus_add_driver) from [] (driver_= register+0x7c/0x114) > > [ 2.684259] [] (driver_register) from [] (do_one= _initcall+0x54/0x2b0) > > [ 2.692441] [] (do_one_initcall) from [] (kernel= _init_freeable+0x1a4/0x1f4) > > [ 2.701145] [] (kernel_init_freeable) from [] (k= ernel_init+0x8/0x118) > > [ 2.709321] [] (kernel_init) from [] (ret_from_f= ork+0x14/0x24) > > [ 2.716885] Exception stack(0xc1501fb0 to 0xc1501ff8) > > [ 2.721933] 1fa0: 00000000 00000= 000 00000000 00000000 > > [ 2.730106] 1fc0: 00000000 00000000 00000000 00000000 00000000 00000= 000 00000000 00000000 > > [ 2.738278] 1fe0: 00000000 00000000 00000000 00000000 00000013 00000= 000 > > [ 2.751940] ---[ end trace 61e3b76deca27ef3 ]--- > >=20 > >=20 > > Cheers > > Jon > >=20 >=20 > Hello Jon, >=20 > That is harmless and expected to happen because the patch "memory: > tegra20: Support hardware versioning and clean up OPP table > initialization" isn't applied yet, while Thierry already applied the DT > patches from this v10. Hmm... that's new. Since when are device tree additions expected to cause these kinds of splats? Anyway, I did apply these because I had seen at least some of the memory controller driver patches appear in linux-next and hence had assumed that the whole series had gone in, not realizing there was anything left to do. Krzysztof, what's your schedule for the memory controller tree? My recollection is that this will feed into ARM SoC, so if the -rc6 dead- line applies like it does for platforms, then I may need to revert the DT patch that causes this so that we don't have to drag this along through all of the release cycle. If there's still time for you to send that PR, perhaps we can get the remainder of the Tegra interconnect series merged for v5.11 as well? Thierry --KMNCFJXxkXYagfyn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl/KW88ACgkQ3SOs138+ s6HidxAAwntnP3WObcRfozgV+UUfPHprx++lvOQM0RSCqz70ZZghhkSfsgcT78Jt yiu2ukYQqQd05H7GHBm0Z844Z2ELYDq8ReYNIOlb4zx0UDr3ooxk0XubcRioei11 hb7rz2p3kXQLduFsNSoCYvlM/GnFE+lKfGwfXCiQn/ZuoHbnUMMOFoESQ/e0bXAW yMogV3lXrxIAyHcUBnohLNMFVD90eaxmcnfCL6og5bRipxipLbyUSlXTOwSiaQdO erTB8q1Dkzlp5b+GOv/nFtLOZQqNFyFm4fK/ijkEeAwbkahx6CFPp+rKUHcgtuJz KIQTFElLLLVBpFKxGoSnN0AFd7FPE5vI58MbOZjCYRNaj15fh1SnrQxl5WtIcett 1K7VgOE/RlcGvLC4krNSVBeZLKIEckZSsAr0ck7fcVz0rU5fyPqz0Uczcfkxe6eT 1u5vz91BiaVL/JUIhpRuoChd2irvpP5tcTiwSs+3d3jyxxuwnmXoJiyqZVtbwNa9 eItaLTkNkt8K9WWjcqnDRgzdWVDdzXh/s1afe/ZFnEcThvHVAU1v06/MrZXfNNeS 6a32RK/iiSenx8/TkYZRWf9aLS5P+Vxn6P90bILPeJND9F0XMiJdrKXTgNwFo8on e/vIrxVuw5KKF6ZyzGjP6cCJgplQLcw5X/luCc+MxA1FzGqV34A= =fKt+ -----END PGP SIGNATURE----- --KMNCFJXxkXYagfyn-- --===============0398311842== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0398311842==--