From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 173BFC4361B for ; Mon, 14 Dec 2020 13:19:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8478220643 for ; Mon, 14 Dec 2020 13:19:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8478220643 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EEF6B6E157; Mon, 14 Dec 2020 13:19:30 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 51A8B6E157 for ; Mon, 14 Dec 2020 13:19:29 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 22BED96; Mon, 14 Dec 2020 14:19:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1607951967; bh=7KGODU/vCu6ZBsxX/92OEQzceiYOciQSwaEJacIF6Xk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DRVSg7meSKNqxrtkdm+IbXWPvyAmRnRhHgzirSvzzfUjm7p6UX8tA5/riUXt99SR+ y4bSXSsdouHQDBOIZrUpEouKYmfCGS/6TpksXAKyC8/HRaWh17r9pZ/4JslDw4GT2p MnfDVPZT0EXJWFvPyEvPjFPcc1XFgK4KgoiNTyPE= Date: Mon, 14 Dec 2020 15:19:21 +0200 From: Laurent Pinchart To: Jacopo Mondi Subject: Re: [PATCH 3/9] drm: rcar-du: Drop unneeded encoder cleanup in error path Message-ID: References: <20201204220139.15272-1-laurent.pinchart+renesas@ideasonboard.com> <20201204220139.15272-4-laurent.pinchart+renesas@ideasonboard.com> <20201214101108.kgdxqmskgz24lfys@uno.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201214101108.kgdxqmskgz24lfys@uno.localdomain> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-renesas-soc@vger.kernel.org, Kuninori Morimoto , Laurent Pinchart , Kieran Bingham , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Jacopo, On Mon, Dec 14, 2020 at 11:11:08AM +0100, Jacopo Mondi wrote: > On Sat, Dec 05, 2020 at 12:01:33AM +0200, Laurent Pinchart wrote: > > The encoder->name field can never be non-null in the error path, as that > > can only be possible after a successful call to > > drm_simple_encoder_init(). Drop the cleanup. > > > > Signed-off-by: Laurent Pinchart > > --- > > drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c > > index 2d40da98144b..0edce24f2053 100644 > > --- a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c > > @@ -124,11 +124,8 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu, > > } > > > > done: > > - if (ret < 0) { > > - if (encoder->name) > > - encoder->funcs->destroy(encoder); > > This is probably worth a Fixes tag, as accessing encoder->func if > drm_simple_encoder_init() has not completed might lead to a NULL > pointer dereference. But in that case encoder->name would be NULL, so encoder->funcs won't be dereferenced. And encoder->name can never be non-NULL here, as explained in the commit message, so this is dead code. I don't think it requires a Fixes: tag. > Apart from this, patch looks good > Reviewed-by: Jacopo Mondi > > > + if (ret < 0) > > devm_kfree(rcdu->dev, renc); > > - } > > > > return ret; > > } -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel