From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CD3CC61DA4 for ; Wed, 22 Feb 2023 14:09:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 573DD10E038; Wed, 22 Feb 2023 14:09:18 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9C4E610E038 for ; Wed, 22 Feb 2023 14:09:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677074956; x=1708610956; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wpLN1gd73bREF0yIjZJYHMzn1mN4hBeaWGTvbEXlUfo=; b=T8MtXUL8tmAxovCNyqSVrFv675wr3l+tkdXjIXzmzlhQUS3C3CoqIiTj 3k9UcFS8YHKBSlJ8ix7i+NOUVy68ReyMSYvjW2VP7/lt2z9hKOHGIo4QZ eI4fMUcQC0Gbb51JcRT1q8fciNnAZaJjnCFVYMqlxNuXrBclTPnohd6yx ysdmfSDUWKsc4cnJNCV4sI4NMUPsbS5l67uPsvuErakfWrhkMxc01jl2k mk21v168KsodEh98eD3VeTOGcvXbL3FAStvY7fLOLqfdsALmi03c+drrA sDbDr1m1FR9S1nGZhDQcH+mvotLNPcSO1Ubbi5Cb7fBd55s5/68yvl8lM w==; X-IronPort-AV: E=McAfee;i="6500,9779,10629"; a="313305569" X-IronPort-AV: E=Sophos;i="5.97,318,1669104000"; d="scan'208";a="313305569" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2023 06:09:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10629"; a="781446604" X-IronPort-AV: E=Sophos;i="5.97,318,1669104000"; d="scan'208";a="781446604" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP; 22 Feb 2023 06:09:07 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pUpne-00ARKq-0t; Wed, 22 Feb 2023 16:08:50 +0200 Date: Wed, 22 Feb 2023 16:08:50 +0200 From: Andy Shevchenko To: Pin-yen Lin Subject: Re: [PATCH v12 03/10] drm/display: Add Type-C switch helpers Message-ID: References: <20230221095054.1868277-1-treapking@chromium.org> <20230221095054.1868277-4-treapking@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heikki Krogerus , Andrzej Hajda , "Rafael J . Wysocki" , dri-devel@lists.freedesktop.org, Douglas Anderson , Laurent Pinchart , Krzysztof Kozlowski , Guenter Roeck , Kees Cook , Marek Vasut , chrome-platform@lists.linux.dev, Robert Foss , Javier Martinez Canillas , Jernej Skrabec , linux-acpi@vger.kernel.org, "Gustavo A. R. Silva" , devicetree@vger.kernel.org, Sakari Ailus , =?iso-8859-1?Q?N=EDcolas_F_=2E_R_=2E_A_=2E?= Prado , Jonas Karlman , Jani Nikula , Allen Chen , Stephen Boyd , Rob Herring , Hsin-Yi Wang , Benson Leung , Xin Ji , AngeloGioacchino Del Regno , Neil Armstrong , Thomas Zimmermann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Daniel Scally , Prashant Malani Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Feb 22, 2023 at 04:53:41PM +0800, Pin-yen Lin wrote: > On Tue, Feb 21, 2023 at 7:48 PM Andy Shevchenko > > On Tue, Feb 21, 2023 at 05:50:47PM +0800, Pin-yen Lin wrote: ... > > > #include > > > #include > > > +#include > > > > I don't see users of this. > > But a few forward declarations are missing. > > I can put a `struct typec_mux_dev;` here, but there is also a usage of > typec_mux_set_fn_t. > > Should I add the typedef into this header file as well? No, inclusion is fine, it's me who didn't notice the type in use. -- With Best Regards, Andy Shevchenko