dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Simon Ser <contact@emersion.fr>
Cc: "Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Jonas Ådahl" <jadahl@redhat.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] Revert "drm: hide unregistered connectors from GETCONNECTOR IOCTL"
Date: Tue, 18 Oct 2022 12:14:09 +0300	[thread overview]
Message-ID: <Y05uYUPoYB25JVpX@intel.com> (raw)
In-Reply-To: <20221017153150.60675-1-contact@emersion.fr>

On Mon, Oct 17, 2022 at 03:31:57PM +0000, Simon Ser wrote:
> This reverts commit 981f09295687f856d5345e19c7084aca481c1395.
> 
> It turns out this breaks Mutter.

A bit more detail would be a good to help future archaeologists.

> 
> Signed-off-by: Simon Ser <contact@emersion.fr>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Jonas Ådahl <jadahl@redhat.com>
> ---
>  drivers/gpu/drm/drm_mode_config.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c
> index 939d621c9ad4..688c8afe0bf1 100644
> --- a/drivers/gpu/drm/drm_mode_config.c
> +++ b/drivers/gpu/drm/drm_mode_config.c
> @@ -151,9 +151,6 @@ int drm_mode_getresources(struct drm_device *dev, void *data,
>  	count = 0;
>  	connector_id = u64_to_user_ptr(card_res->connector_id_ptr);
>  	drm_for_each_connector_iter(connector, &conn_iter) {
> -		if (connector->registration_state != DRM_CONNECTOR_REGISTERED)
> -			continue;
> -
>  		/* only expose writeback connectors if userspace understands them */
>  		if (!file_priv->writeback_connectors &&
>  		    (connector->connector_type == DRM_MODE_CONNECTOR_WRITEBACK))
> -- 
> 2.38.0
> 

-- 
Ville Syrjälä
Intel

  parent reply	other threads:[~2022-10-18  9:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17 15:31 [PATCH 1/2] Revert "drm: hide unregistered connectors from GETCONNECTOR IOCTL" Simon Ser
2022-10-17 15:32 ` [PATCH 2/2] drm/connector: send hotplug uevent on connector cleanup Simon Ser
2022-10-17 15:34   ` Jonas Ådahl
2022-10-17 19:08   ` Lyude Paul
2022-10-18  9:24   ` Ville Syrjälä
2022-10-18  9:26     ` Simon Ser
2022-10-18  9:14 ` Ville Syrjälä [this message]
2022-10-18  9:27   ` [PATCH 1/2] Revert "drm: hide unregistered connectors from GETCONNECTOR IOCTL" Jonas Ådahl
2022-10-18  9:58     ` Ville Syrjälä
2022-10-18 10:07       ` Jonas Ådahl
2022-10-18 11:06         ` Ville Syrjälä
2022-11-15  8:51 ` Jonas Ådahl
2022-11-15  8:55   ` Simon Ser
2022-11-15  9:18     ` Jonas Ådahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y05uYUPoYB25JVpX@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=contact@emersion.fr \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jadahl@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).