From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70D1AECAAA1 for ; Mon, 24 Oct 2022 11:34:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 63D7110E38A; Mon, 24 Oct 2022 11:34:15 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 875C310E38A; Mon, 24 Oct 2022 11:34:11 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id E7984CE1316; Mon, 24 Oct 2022 11:34:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 319D0C433C1; Mon, 24 Oct 2022 11:34:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666611247; bh=XONUYrrBTIpNDIVeQuanVcQ94OVXm/q30QmP4QTO20M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sAQ8DdUTn4cA4kXBumIiWfgCwZj8r++TXQs31zZ9q2+/MniKi1/s9M+kJykih7j0A BqF0YmiSmJB6PuGkssIdCnKPxV5B/gTla9yErlk0SoVDIeZlZQE2J2YU9dSlM1hJHU OhMBypH7gjMmdD0xcPXyT/X59MRJRufxXiKMCu2eWqm0hu353yVHeJHmuQVFsYUMIW LH/cB0bDDcRc1pGLgxQpuYhs7ZMW6yCvvMxuOGnZP//S+Owfjx+QZDbNLtwPQi5nMz o80e4z2fIZgkn5jOIm7wQSEvg6P22nA9KGNllj2gEjIPXKTfraSyfbII3HaJaBSk8T 7+l0vbOwjVBYA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1omviI-0006Ky-GC; Mon, 24 Oct 2022 13:33:50 +0200 Date: Mon, 24 Oct 2022 13:33:50 +0200 From: Johan Hovold To: Abhinav Kumar Subject: Re: [PATCH v2 00/10] drm/msm: probe deferral fixes Message-ID: References: <20220913085320.8577-1-johan+linaro@kernel.org> <139426b9-0e5b-e4c3-27c6-584ab48517c2@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <139426b9-0e5b-e4c3-27c6-584ab48517c2@quicinc.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Neil Armstrong , Jernej Skrabec , linux-kernel@vger.kernel.org, Jonas Karlman , linux-arm-msm@vger.kernel.org, Bjorn Andersson , freedreno@lists.freedesktop.org, Douglas Anderson , Robert Foss , Stephen Boyd , Laurent Pinchart , Andrzej Hajda , Manivannan Sadhasivam , Dmitry Baryshkov , Kuogee Hsieh , Sean Paul , Steev Klimaszewski Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Oct 21, 2022 at 09:05:52AM -0700, Abhinav Kumar wrote: > Hi Johan > > On 10/20/2022 11:27 PM, Johan Hovold wrote: > > On Tue, Sep 20, 2022 at 11:06:30AM +0200, Johan Hovold wrote: > >> On Tue, Sep 13, 2022 at 10:53:10AM +0200, Johan Hovold wrote: > >>> The MSM DRM driver is currently broken in multiple ways with respect to > >>> probe deferral. Not only does the driver currently fail to probe again > >>> after a late deferral, but due to a related use-after-free bug this also > >>> triggers NULL-pointer dereferences. > >>> > >>> These bugs are not new but have become critical with the release of > >>> 5.19 where probe is deferred in case the aux-bus EP panel driver has not > >>> yet been loaded. > >>> > >>> The underlying problem is lifetime issues due to careless use of > >>> device-managed resources. > >> > >> Any chance of getting this merged for 6.1? > > > > Is anyone picking these up as fixes for 6.1-rc as we discussed? > > > > Johan > > All of these except the last two ( as discussed ) have landed in the > -fixes tree > > https://gitlab.freedesktop.org/drm/msm/-/commit/6808abdb33bf90330e70a687d29f038507e06ebb Ah, perfect, thanks. When do you expect to send these on so that they end up in linux-next and eventually Linus's tree? Note that it looks like something happened with the commit messages when you applied these. Specifically, the Fixes tags appears to now have a line break in them and there's also some random whitespace before your SoB: Fixes: c3bf8e21 ("drm/msm/dp: Add eDP support via aux_bus") Cc: stable@vger.kernel.org # 5.19 Reviewed-by: Dmitry Baryshkov Signed-off-by: Johan Hovold Tested-by: Kuogee Hsieh Reviewed-by: Kuogee Hsieh Patchwork: https://patchwork.freedesktop.org/patch/502667/ Link: https://lore.kernel.org/r/20220913085320.8577-8-johan+linaro@kernel.org Signed-off-by: Abhinav Kumar's avatarAbhinav Kumar It's possible just the gitlab UI that's messed up, but perhaps you can double check before they hit linux-next, which should complain about this otherwise. Johan