From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 138C5C3DA7D for ; Tue, 3 Jan 2023 07:58:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A87AC10E39D; Tue, 3 Jan 2023 07:58:15 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA26510E241 for ; Tue, 3 Jan 2023 07:58:13 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C7224B80E14; Tue, 3 Jan 2023 07:58:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80D61C433EF; Tue, 3 Jan 2023 07:58:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672732690; bh=CZjw7I9UxotlvvY8MEtD8ZW6aSrpDpY1IbdlOy4X8H0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jSlMbOct+Wj8OWic7zBFHd2d/tTsozpcHztyI0h/qZgLuR7MZBwUlycJ0RBSY5lMP /OfOttfH40FC+QxomJWDgFbcFMqBC78pp1lpnhxXxs1OAixTxsI7OcaBI/0+tt4Ghl hhk04j9qK44t8aXQmmtMuMtSBvPWyb5Z8EynZQNUci0lW+r0aZ4Q9VFzRanESmSML1 N4wTsLr+uChAuVlbd8fSttgeJaBPmXcO05piBzjUcx8TyjiE9zXP1xlOME8QFmkVgT aDsvkQaDv1lKjeU56UEMAZxo1EzFnKxKHD7BvQGKOCy9TL7F0BnryON9/s7FLXjV2u naBV5uTNJx4Mg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1pCcBp-0005dq-Ig; Tue, 03 Jan 2023 08:58:29 +0100 Date: Tue, 3 Jan 2023 08:58:29 +0100 From: Johan Hovold To: Abel Vesa Subject: Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b Message-ID: References: <20221231142721.338643-1-abel.vesa@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sam Ravnborg , Douglas Anderson , Steev Klimaszewski , linux-kernel@vger.kernel.org, Thierry Reding , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jan 03, 2023 at 12:36:51AM +0200, Abel Vesa wrote: > On 23-01-02 09:21:40, Johan Hovold wrote: > > On Sun, Jan 01, 2023 at 10:58:42PM -0600, Steev Klimaszewski wrote: > > > On Sat, Dec 31, 2022 at 8:27 AM Abel Vesa wrote: > > > > > > > > The actual name is R133NW4K-R0. > > > > > > > > Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry") > > > > Signed-off-by: Abel Vesa > > > > --- > > > > > > > > Assuming the information from here is correct: > > > > https://raw.githubusercontent.com/linuxhw/EDID/master/DigitalDisplay.md > > > Thanks for this - when I was looking for the panel, I simply went with > > > what I found on panel-look. > > > > Did you check what string your panel reports? For example, using > > something like: > > > > # strings /sys/class/drm/card0-eDP-1/edid > > ... > > B133UAN02.1 > > Mine shows: M133NW4J R3 > > But since both R0 and R3 have the same product ID, I decided to drop the > revision part, otherwise we would need to add a second entry with the > only difference between them being the revision part (Rx). This is what > I did in patch #2. Makes sense. Thanks for confirming. Johan