Re: [PATCH] drm/vkms: Add a DRM render node to vkms

[Daniel Vetter <daniel@ffwll.ch>]

On Thu, Jan 05, 2023 at 02:23:25PM +0900, Yi Xie wrote:
> Some libraries including Mesa and virglrenderer require a render node to
> fully function. By adding a render node to vkms those libraries will
> work properly, supporting use cases like running crosvm with virgl GPU
> support via llvmpipe on a headless virtual machine.

This is what vgem exists for. More or less at least ... I'm honestly not
really understanding what you're trying to fix here, it sounds a bit like
userspace being stupid.
-Daniel

> 
> Signed-off-by: Yi Xie <yixie@google.com>
> ---
>  drivers/gpu/drm/vkms/vkms_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 293dbca50c31..8eea5d4dece8 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -113,7 +113,7 @@ static void vkms_config_debugfs_init(struct drm_minor *minor)
>  }
>  
>  static const struct drm_driver vkms_driver = {
> -	.driver_features	= DRIVER_MODESET | DRIVER_ATOMIC | DRIVER_GEM,
> +	.driver_features	= DRIVER_MODESET | DRIVER_ATOMIC | DRIVER_GEM | DRIVER_RENDER,
>  	.release		= vkms_release,
>  	.fops			= &vkms_driver_fops,
>  	DRM_GEM_SHMEM_DRIVER_OPS,
> -- 
> 2.39.0.314.g84b9a713c41-goog
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch