From: Sam Ravnborg <sam@ravnborg.org>
To: xinlei.lee@mediatek.com
Cc: chunkuang.hu@kernel.org, jitao.shi@mediatek.com,
airlied@linux.ie, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
thierry.reding@gmail.com, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org,
angelogioacchino.delregno@collabora.com
Subject: Re: [PATCH 2/2] drm/panel: boe-tv101wum-nl6: Reduce lcm_reset to send initial code time
Date: Sat, 7 Jan 2023 21:31:01 +0100 [thread overview]
Message-ID: <Y7nWhciY7cru78lQ@ravnborg.org> (raw)
In-Reply-To: <1672974321-18947-3-git-send-email-xinlei.lee@mediatek.com>
On Fri, Jan 06, 2023 at 11:05:21AM +0800, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.com>
>
> Since the panel spec stipulates that the time from lcm_reset to DSI to
> send the initial code should be greater than 6ms and less than 40ms,
> so reduce the delay before sending the initial code and avoid panel
> exceptions.
The changelog says "reduce the delay", but the patch removes the delay.
Are there other delays that make sure the "greater than 6 ms" is OK?
Sam
>
> Fixes: a869b9db7adf ("drm/panel: support for boe tv101wum-nl6 wuxga dsi video mode panel")
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com>
> ---
> drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> index 857a2f0420d7..f0093035f1ff 100644
> --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> @@ -780,7 +780,6 @@ static const struct panel_init_cmd inx_hj110iz_init_cmd[] = {
> };
>
> static const struct panel_init_cmd boe_init_cmd[] = {
> - _INIT_DELAY_CMD(24),
> _INIT_DCS_CMD(0xB0, 0x05),
> _INIT_DCS_CMD(0xB1, 0xE5),
> _INIT_DCS_CMD(0xB3, 0x52),
> --
> 2.18.0
next prev parent reply other threads:[~2023-01-07 20:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 3:05 [PATCH 0/2]Reduce lcm_reset to DSI LP11 send cmd time xinlei.lee
2023-01-06 3:05 ` [PATCH 1/2] drm/mediatek: dsi: Reduce the time of dsi from LP11 to sending cmd xinlei.lee
2023-01-07 20:29 ` Sam Ravnborg
2023-01-09 11:26 ` AngeloGioacchino Del Regno
2023-01-06 3:05 ` [PATCH 2/2] drm/panel: boe-tv101wum-nl6: Reduce lcm_reset to send initial code time xinlei.lee
2023-01-07 20:31 ` Sam Ravnborg [this message]
2023-01-09 11:58 ` Xinlei Lee (李昕磊)
2023-01-12 7:26 ` Xinlei Lee (李昕磊)
2023-01-09 11:25 ` AngeloGioacchino Del Regno
2023-01-09 11:54 ` Xinlei Lee (李昕磊)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7nWhciY7cru78lQ@ravnborg.org \
--to=sam@ravnborg.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=airlied@linux.ie \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jitao.shi@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=xinlei.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox