From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 875D0C25B50 for ; Mon, 23 Jan 2023 09:51:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A640B10E1E8; Mon, 23 Jan 2023 09:51:30 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7E50A10E1E8 for ; Mon, 23 Jan 2023 09:51:29 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D193C60E00; Mon, 23 Jan 2023 09:51:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B19F0C433EF; Mon, 23 Jan 2023 09:51:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1674467488; bh=I1TFqfaAYrE67AWuhwWFFkrdbPVOTogsIu0uGhqZTMc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KUjTYbl3HSo04F7350eYhPO++nuP3ClQEi4/mYv1LTVeS1HcAahmC6f3QiKxhUSK0 cLhlfWr9Tgcf8Fn8o9sDFM23S4fteDSwKEB7WdAOV2uJCMLLeH4TuKVCzlUPB6zwq+ mmhUIZWAHUv1EUx8mlzjIDzcy0s4w25PHrPB6w+0= Date: Mon, 23 Jan 2023 10:51:25 +0100 From: Greg Kroah-Hartman To: Li Chen Subject: Re: [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port Message-ID: References: <20230123073305.149940-1-lchen@ambarella.com> <20230123073305.149940-11-lchen@ambarella.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230123073305.149940-11-lchen@ambarella.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sumit Semwal , open list , "open list:DMA BUFFER SHARING FRAMEWORK" , Li Chen , "moderated list:DMA BUFFER SHARING FRAMEWORK" , "open list:SERIAL DRIVERS" , Jiri Slaby , Christian =?iso-8859-1?Q?K=F6nig?= , "moderated list:ARM/Ambarella SoC support" , "open list:DMA BUFFER SHARING FRAMEWORK" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Jan 23, 2023 at 03:32:25PM +0800, Li Chen wrote: > This driver add support for Ambarella's uart, which > can be used for console and etc. > > Signed-off-by: Li Chen > Change-Id: Ie68af7ad2187e21853e58d52cd97fd7145303730 > --- > MAINTAINERS | 1 + > drivers/tty/serial/Kconfig | 16 + > drivers/tty/serial/Makefile | 1 + > drivers/tty/serial/ambarella_uart.c | 1581 +++++++++++++++++++++++++++ > drivers/tty/serial/ambarella_uart.h | 120 ++ Why do you need a .h file for a single .c file? They should all be in one file please. Also, no change-id, you know this... thanks, greg k-h