dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Riesen <alexander.riesen@cetitec.com>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
	Ben Skeggs <bskeggs@redhat.com>,
	nouveau <nouveau@lists.freedesktop.org>,
	Dave Airlie <airlied@redhat.com>
Subject: Re: [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace
Date: Wed, 24 Feb 2021 18:02:47 +0100	[thread overview]
Message-ID: <YDaGtzRDUIbErYDY@pflmari> (raw)
In-Reply-To: <CAKb7UviFdgqqSrFvZJzfenaKa_0P6hJ4SaDrwA39Lz8jVigDGw@mail.gmail.com>

Ilia Mirkin, Wed, Feb 24, 2021 17:57:41 +0100:
> On Wed, Feb 24, 2021 at 11:53 AM Alex Riesen <alexander.riesen@cetitec.com> wrote:
> > Ilia Mirkin, Wed, Feb 24, 2021 17:48:39 +0100:
> > > Just to be crystal clear -- are you saying that 128x128 works or does
> > > not work? (You said "yes", which would imply it works OK, but then you
> > > said both cases, which would imply doesn't work since 256x256 doesn't
> > > work?)
> >
> > Modetest with 128x128 cursor works. Without damage to the cursor: modetest
> > shows normal cursor in vanilla v5.11. Modetest also shows normal cursor in
> > vanilla v5.11 with the commit reverted.
> 
> But modetest with 256x256 doesn't work (correctly) right? Or did I
> misunderstand?

Right. That's why I was asking if I did everything right: it was just corrupted
in both kernels.

> All the patch does is allow those large cursors to be used, which gets
> reported via drm APIs and modesetting picks the largest cursor
> available. (And actually I think it's even not required to use the
> large cursors, it just controls what's reported in the defaults to
> userspace.)

Maybe something in X code is not prepared to handle the kernel reporting
large cursor support? Even though 128x128 is pretty large, and I don't think
I even use that large cursors in X configuration. How can I check?

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2021-02-24 17:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19  1:54 [PATCH 1/3] drivers/nouveau/kms/nv50-: Reject format modifiers for cursor planes Lyude Paul
2021-01-19  1:54 ` [PATCH 2/3] drm/nouveau/kms/nv50-: Report max cursor size to userspace Lyude Paul
2021-01-19 10:22   ` Simon Ser
2021-02-23 14:15   ` Alex Riesen
2021-02-23 14:56     ` Ilia Mirkin
2021-02-23 15:36       ` Alex Riesen
2021-02-23 15:46         ` Ilia Mirkin
2021-02-23 15:51           ` Alex Riesen
2021-02-23 16:22             ` Alex Riesen
2021-02-23 18:13               ` Ilia Mirkin
2021-02-24  9:08                 ` Alex Riesen
2021-02-24 15:10                   ` Ilia Mirkin
2021-02-24 16:35                     ` Alex Riesen
2021-02-24 16:48                       ` Ilia Mirkin
2021-02-24 16:53                         ` Alex Riesen
2021-02-24 16:57                           ` Ilia Mirkin
2021-02-24 17:02                             ` Alex Riesen [this message]
2021-02-24 17:47                               ` Ilia Mirkin
2021-01-19  1:54 ` [PATCH 3/3] drm/nouveau/kms/nve4-nv138: Fix > 64x64 cursors Lyude Paul
2021-01-19 10:18 ` [PATCH 1/3] drivers/nouveau/kms/nv50-: Reject format modifiers for cursor planes Simon Ser
2021-01-19 15:50 ` Ville Syrjälä
2021-01-19 15:52 ` James Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YDaGtzRDUIbErYDY@pflmari \
    --to=alexander.riesen@cetitec.com \
    --cc=airlied@redhat.com \
    --cc=bskeggs@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imirkin@alum.mit.edu \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox