dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alyssa Rosenzweig <alyssa@collabora.com>
To: Jason Ekstrand <jason@jlekstrand.net>
Cc: Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
	Steven Price <steven.price@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	Robin Murphy <robin.murphy@arm.com>
Subject: Re: [RFC PATCH 0/7] drm/panfrost: Add a new submit ioctl
Date: Thu, 11 Mar 2021 22:38:54 +0000	[thread overview]
Message-ID: <YEqb/tB++F5aaY0r@maud> (raw)
In-Reply-To: <CAOFGe95d-LQ_rNwncup-G5oj14uCnNrnHr=r1b5jLYnXfMSTiA@mail.gmail.com>

> I'm not familiar with panfrost's needs and I don't work on a tiler and
> I know there are different issues there.  But...

The primary issue is we submit vertex+compute and fragment for each
batch as two disjoint jobs (with a dependency of course), reflecting the
internal hardware structure as parallel job slots. That we actually
require two ioctls() and a roundtrip for this is a design wart inherited
from early days of the kernel driver. The downstream Mali driver handles
this by allowing multiple jobs to be submitted with a single ioctl, as
Boris's patch enables. In every other respect I believe our needs are
similar to other renderonly drivers. (What does turnip do?)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2021-03-11 22:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-11  9:25 [RFC PATCH 0/7] drm/panfrost: Add a new submit ioctl Boris Brezillon
2021-03-11  9:25 ` [RFC PATCH 1/7] drm/panfrost: Pass a job to panfrost_{acquire, attach_object_fences}() Boris Brezillon
2021-03-11  9:25 ` [RFC PATCH 2/7] drm/panfrost: Collect implicit and explicit deps in an XArray Boris Brezillon
2021-03-11  9:25 ` [RFC PATCH 3/7] drm/panfrost: Move the mappings collection out of panfrost_lookup_bos() Boris Brezillon
2021-03-11  9:25 ` [RFC PATCH 4/7] drm/panfrost: Add BO access flags to relax dependencies between jobs Boris Brezillon
2021-03-11  9:25 ` [RFC PATCH 5/7] drm/panfrost: Add a new ioctl to submit batches Boris Brezillon
2021-03-11  9:25 ` [RFC PATCH 6/7] drm/panfrost: Advertise the SYNCOBJ_TIMELINE feature Boris Brezillon
2021-03-11  9:25 ` [RFC PATCH 7/7] drm/panfrost: Bump minor version to reflect the feature additions Boris Brezillon
2021-03-11 12:16 ` [RFC PATCH 0/7] drm/panfrost: Add a new submit ioctl Steven Price
2021-03-11 13:00   ` Boris Brezillon
2021-03-11 16:58     ` Jason Ekstrand
2021-03-11 17:24       ` Boris Brezillon
2021-03-11 18:11         ` Jason Ekstrand
2021-03-11 22:38           ` Alyssa Rosenzweig [this message]
2021-03-12  7:31           ` Boris Brezillon
2021-03-12 15:37             ` Jason Ekstrand
2021-03-12 18:25               ` Boris Brezillon
2021-03-12 20:06                 ` Boris Brezillon
2021-03-12 21:48                 ` Alyssa Rosenzweig
2021-03-12 14:15   ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEqb/tB++F5aaY0r@maud \
    --to=alyssa@collabora.com \
    --cc=alyssa.rosenzweig@collabora.com \
    --cc=boris.brezillon@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jason@jlekstrand.net \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=steven.price@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox