From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B68BC43460 for ; Tue, 4 May 2021 12:59:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0DAD2613BC for ; Tue, 4 May 2021 12:59:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0DAD2613BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 752836E214; Tue, 4 May 2021 12:59:12 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FC0B6E214 for ; Tue, 4 May 2021 12:59:10 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9E030613B4; Tue, 4 May 2021 12:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1620133150; bh=VKrAeZZpludZjTm6WuzJcgg7371nyGiXlt3bsLCkX3c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1RVOhA+xUnttg6X+/OXWdWei9lFiPRvoAUP4JZ66jwCl3Fwz8Y9JcIZ2dWfl4AXDh Mg7CS6WUOwTfkw4umLIPAtPqY5sJ9P6hfLWa3HEE2n4liAZAnteKFXFxaUW5xREyNd jljZ143srAqD73QuO6fQW2meQYvxR3Y6pcFbbX8Q= Date: Tue, 4 May 2021 14:59:07 +0200 From: Greg Kroah-Hartman To: Greg Kurz Subject: Re: remove the nvlink2 pci_vfio subdriver v2 Message-ID: References: <20210326061311.1497642-1-hch@lst.de> <20210504142236.76994047@bahia.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210504142236.76994047@bahia.lan> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, David Airlie , Michael Ellerman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, qemu-devel@nongnu.org, Alex Williamson , Paul Mackerras , Jason Gunthorpe , linux-api@vger.kernel.org, qemu-ppc@nongnu.org, linuxppc-dev@lists.ozlabs.org, Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, May 04, 2021 at 02:22:36PM +0200, Greg Kurz wrote: > On Fri, 26 Mar 2021 07:13:09 +0100 > Christoph Hellwig wrote: > > > Hi all, > > > > the nvlink2 vfio subdriver is a weird beast. It supports a hardware > > feature without any open source component - what would normally be > > the normal open source userspace that we require for kernel drivers, > > although in this particular case user space could of course be a > > kernel driver in a VM. It also happens to be a complete mess that > > does not properly bind to PCI IDs, is hacked into the vfio_pci driver > > and also pulles in over 1000 lines of code always build into powerpc > > kernels that have Power NV support enabled. Because of all these > > issues and the lack of breaking userspace when it is removed I think > > the best idea is to simply kill. > > > > Changes since v1: > > - document the removed subtypes as reserved > > - add the ACK from Greg > > > > Diffstat: > > arch/powerpc/platforms/powernv/npu-dma.c | 705 --------------------------- > > b/arch/powerpc/include/asm/opal.h | 3 > > b/arch/powerpc/include/asm/pci-bridge.h | 1 > > b/arch/powerpc/include/asm/pci.h | 7 > > b/arch/powerpc/platforms/powernv/Makefile | 2 > > b/arch/powerpc/platforms/powernv/opal-call.c | 2 > > b/arch/powerpc/platforms/powernv/pci-ioda.c | 185 ------- > > b/arch/powerpc/platforms/powernv/pci.c | 11 > > b/arch/powerpc/platforms/powernv/pci.h | 17 > > b/arch/powerpc/platforms/pseries/pci.c | 23 > > b/drivers/vfio/pci/Kconfig | 6 > > b/drivers/vfio/pci/Makefile | 1 > > b/drivers/vfio/pci/vfio_pci.c | 18 > > b/drivers/vfio/pci/vfio_pci_private.h | 14 > > b/include/uapi/linux/vfio.h | 38 - > > > Hi Christoph, > > FYI, these uapi changes break build of QEMU. What uapi changes? What exactly breaks? Why does QEMU require kernel driver stuff? thanks, greg k-h _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel