From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CCEFC48BE5 for ; Thu, 17 Jun 2021 08:06:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5FD161209 for ; Thu, 17 Jun 2021 08:06:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5FD161209 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4A5846E89C; Thu, 17 Jun 2021 08:06:36 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id E0B526E89C; Thu, 17 Jun 2021 08:06:35 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id DD8C0610A0; Thu, 17 Jun 2021 08:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623917195; bh=YuScG7SzWSSRa8w1px2qbFZAuK3KvyU2T8TThbFj484=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KZtZND8jBB1VBzwKJ37okD6sz+7yOm9yfkVXZvMIlMjMbU+/QQz+2xByOFDnV5kBI 6efKtbVV9eT5xS4zzlnh8n7ZsNw9HbZ9sDLEp85/CilwlCFxqxCmQTdmDzguDQa7Lp 4x2Vb3YyD9PDnbpAeR5LjMTKQ1CrYzZ7y+T6cKTgZhf9ln2FEaUfw4ZsIG57QvUrn+ mYwOMefXgMUm+fnsHxN3SSZb5+ntdFmtUv2FZAMaHM6Nw2i3Q4grHbNXZezuo5XuAw 2Pb+WKjNG8oat7wV5SyAWARDp1KJqOMhozk0z+QSanSSEdBFilprNmu6ZdBXqQ2fFd yOrn1FJC0gCnw== Date: Thu, 17 Jun 2021 13:36:32 +0530 From: Vinod Koul To: abhinavk@codeaurora.org Subject: Re: [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support Message-ID: References: <20210521124946.3617862-1-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: DTML , Jonathan Marek , Jeffrey Hugo , David Airlie , MSM , lkml , "open list:DRM PANEL DRIVERS" , Bjorn Andersson , Rob Clark , Rob Herring , Dmitry Baryshkov , freedreno Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 03-06-21, 16:40, abhinavk@codeaurora.org wrote: > On 2021-06-02 04:01, Vinod Koul wrote: > > On 27-05-21, 16:30, Rob Clark wrote: > > > > yeah that is always a very different world. although it might make sense > > to use information in tables and try to deduce information about the > > system can be helpful... > > > > > I'd worry more about what makes sense in a DT world, when it comes to > > > DT bindings. > > > > And do you have thoughts on that..? > > At the moment, I will comment on the bindings first and my idea on how to > proceed. > The bindings mentioned here: > https://lore.kernel.org/dri-devel/20210521124946.3617862-3-vkoul@kernel.org/ > seem to be just > taken directly from downstream which was not the plan. > > I think all of these should be part of the generic panel bindings as none of > these are QC specific: Okay so we have discussed this w/ Bjorn and Abhinav and here are the conclusions and recommendations for binding 1. the properties are generic and not msm specific 2. The host supports multiple formats but the one we choose depends mostly upon panel. Notably host runs the config which the panel supports. So the recommendations is to add a table of dsc properties in the panel driver. No DT binding here. I should also note that for DP we should be able to calculate these values from EDID like the i915 driver seems to do With this I will drop the binding patch and move dsc properties to panel driver Thanks -- ~Vinod