From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D282C07E99 for ; Fri, 9 Jul 2021 18:12:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB290613B2 for ; Fri, 9 Jul 2021 18:12:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB290613B2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3F9B86E97F; Fri, 9 Jul 2021 18:12:13 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E8C16E97F for ; Fri, 9 Jul 2021 18:12:12 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 3175423e-e0e1-11eb-8d1a-0050568cd888; Fri, 09 Jul 2021 18:12:16 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id D0559194B04; Fri, 9 Jul 2021 20:12:19 +0200 (CEST) Date: Fri, 9 Jul 2021 20:12:08 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Yunus Bas Subject: Re: [PATCH v3 2/2] drm/panel: simple: Add support for EDT ETM0350G0DH6 panel Message-ID: References: <20210706075908.907659-1-y.bas@phytec.de> <20210706075908.907659-2-y.bas@phytec.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210706075908.907659-2-y.bas@phytec.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, thierry.reding@gmail.com, laurent.pinchart@ideasonboard.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Yunus, On Tue, Jul 06, 2021 at 09:59:08AM +0200, Yunus Bas wrote: > From: Stefan Riedmueller > > This patch adds support for the EDT ETM0350G0DH6 3.5" (320x240) lcd > panel to DRM simple panel driver. > > Signed-off-by: Stefan Riedmueller > Signed-off-by: Yunus Bas > --- > Changes in v3: > - No changes in general, added additional maintainers and also sending > to general kernel mailing list > --- > drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 07433bff6c2b..8aba473a7592 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1929,6 +1929,32 @@ static const struct panel_desc edt_et035012dm6 = { > .bus_flags = DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE, > }; > > +static const struct drm_display_mode edt_etm0350g0dh6_mode = { > + .clock = 6520, > + .hdisplay = 320, > + .hsync_start = 320 + 20, > + .hsync_end = 320 + 20 + 68, > + .htotal = 320 + 20 + 68, > + .vdisplay = 240, > + .vsync_start = 240 + 4, > + .vsync_end = 240 + 4 + 18, > + .vtotal = 240 + 4 + 18, > + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, > +}; > + > +static const struct panel_desc edt_etm0350g0dh6 = { > + .modes = &edt_etm0350g0dh6_mode, > + .num_modes = 1, > + .bpc = 6, > + .size = { > + .width = 70, > + .height = 53, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, > + .connector_type = DRM_MODE_CONNECTOR_DPI, > +}; > + > static const struct drm_display_mode edt_etm043080dh6gp_mode = { > .clock = 10870, > .hdisplay = 480, > @@ -4355,6 +4381,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "edt,et035012dm6", > .data = &edt_et035012dm6, > + }, { > + .compatible = "edt,etm0350g0dh6", > + .data = &edt_etm0350g0dh6, The compatible "edt,etm0350g0dh6" is not documented. You likely need to add it to panel-simple.yaml - and likewise for the first patch. dt people like binding patches in separate patches so add them both in one dedicated patch. Sam