From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41B48C07E95 for ; Sat, 10 Jul 2021 09:59:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C700761205 for ; Sat, 10 Jul 2021 09:59:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C700761205 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 334306EB19; Sat, 10 Jul 2021 09:59:28 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6832E6EB19 for ; Sat, 10 Jul 2021 09:59:26 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 857f2c5c-e165-11eb-8d1a-0050568cd888; Sat, 10 Jul 2021 09:59:31 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 3AF6D194B15; Sat, 10 Jul 2021 11:59:34 +0200 (CEST) Date: Sat, 10 Jul 2021 11:59:22 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Paul Cercueil Subject: Re: [PATCH 1/2] dt-bindings: display/panel: Add Innolux EJ030NA Message-ID: References: <20210625121045.81711-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , Thierry Reding , list@opendingux.net, Christophe Branchereau Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Paul, > > > + backlight: true > > > + port: true > > > + power-supply: true > > > + reg: true > > > + reset-gpios: true > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - power-supply > > > + - reset-gpios > > > + > > > +unevaluatedProperties: false > > I had expected: > > additionalProperties: false > > > > With this fixed: > > Reviewed-by: Sam Ravnborg > > I am not sure; the doc states that this (additionalProperties: false) "can't > be used in case where another schema is referenced", which is the case here, > as we include "panel-common.yaml". This DT schema already list all relevant properties like: backlight: true So "additionalProperties: false" tells that no other properties are allowed other than the listed properties. To my best understanding unevaluatedProperties: false is less strict and should be used if one does not list all possilbe properties. This could be the case for a panel haging below a SPI controller as in this case. So in other words giving this some extra thought I think unevaluatedProperties: false is OK here. So my r-b is ok if you keep it as it. PS. Where do you guys hang out with the downfall of freenode - somewhere on oftc? Sam