From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5784DC07E95 for ; Sat, 10 Jul 2021 20:47:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCD736135B for ; Sat, 10 Jul 2021 20:47:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCD736135B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CCE286EB5C; Sat, 10 Jul 2021 20:47:13 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id D0BBC6EB5C for ; Sat, 10 Jul 2021 20:47:11 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A0B4255; Sat, 10 Jul 2021 22:47:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1625950030; bh=aqz/R+qpR7KL+fyTu819jnjletiIJ66CngXDNMV3aaE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q6ky447ioQ9QFBpGUWHZsfByijgzoYLHBzAhrWlBEtFHBPH91zm9I3a1CGf5CcKJ/ 8lBMYqr2VFC0kl7HLllmk1T3JZb465g0jXVM2xSIG9SQLrNs6yzwYAjFrvzl/b5VgI 2Q7ggsw3SL/FjPCX42w+ax3t9ogJ9SXY5O1v2dck= Date: Sat, 10 Jul 2021 23:46:24 +0300 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH 1/1] drm: bridge: Mark deprecated operations in drm_bridge_funcs Message-ID: References: <20210710084240.281063-1-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210710084240.281063-1-sam@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Andrzej Hajda , dri-devel@lists.freedesktop.org, Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sam, Thank you for the patch. On Sat, Jul 10, 2021 at 10:42:40AM +0200, Sam Ravnborg wrote: > drm_bridge_funcs includes several duplicated operations as atomic > variants has been added over time. s/has/have/ > New bridge drivers shall use the atomic variants - mark the deprecated > operations to try to avoid usage in new bridge drivers. > > Signed-off-by: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Andrzej Hajda > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter > --- > include/drm/drm_bridge.h | 28 ++++++++++++++++++++++++++-- > 1 file changed, 26 insertions(+), 2 deletions(-) > > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > index 2195daa289d2..6805898d70f5 100644 > --- a/include/drm/drm_bridge.h > +++ b/include/drm/drm_bridge.h > @@ -171,6 +171,11 @@ struct drm_bridge_funcs { > * signals) feeding it is still running when this callback is called. > * > * The @disable callback is optional. > + * > + * NOTE: > + * > + * This is deprecated, do not use! > + * New drivers shall use &drm_bridge_funcs.atomic_disable. > */ > void (*disable)(struct drm_bridge *bridge); > > @@ -190,6 +195,11 @@ struct drm_bridge_funcs { > * called. > * > * The @post_disable callback is optional. > + * > + * NOTE: > + * > + * This is deprecated, do not use! > + * New drivers shall use &drm_bridge_funcs.atomic_post_disable. > */ > void (*post_disable)(struct drm_bridge *bridge); > > @@ -213,11 +223,15 @@ struct drm_bridge_funcs { > * For atomic drivers the adjusted_mode is the mode stored in > * &drm_crtc_state.adjusted_mode. > * > - * NOTE: > - * > * If a need arises to store and access modes adjusted for other > * locations than the connection between the CRTC and the first bridge, > * the DRM framework will have to be extended with DRM bridge states. The DRM framework *has* been extended with DRM bridge states :-) Should this be dropped ? Reviewed-by: Laurent Pinchart > + * > + * NOTE: > + * > + * This is deprecated, do not use! > + * New drivers shall set their mode in &drm_bridge_funcs.atomic_enable > + * operation. > */ > void (*mode_set)(struct drm_bridge *bridge, > const struct drm_display_mode *mode, > @@ -239,6 +253,11 @@ struct drm_bridge_funcs { > * there is one) when this callback is called. > * > * The @pre_enable callback is optional. > + * > + * NOTE: > + * > + * This is deprecated, do not use! > + * New drivers shall use &drm_bridge_funcs.atomic_pre_enable. > */ > void (*pre_enable)(struct drm_bridge *bridge); > > @@ -259,6 +278,11 @@ struct drm_bridge_funcs { > * chain if there is one. > * > * The @enable callback is optional. > + * > + * NOTE: > + * > + * This is deprecated, do not use! > + * New drivers shall use &drm_bridge_funcs.atomic_enable. > */ > void (*enable)(struct drm_bridge *bridge); > -- Regards, Laurent Pinchart