Re: [PATCH 1/1] drm: bridge: Mark deprecated operations in drm_bridge_funcs

[Sam Ravnborg <sam@ravnborg.org>]

Hi Laurent,

On Sat, Jul 10, 2021 at 11:46:24PM +0300, Laurent Pinchart wrote:
> Hi Sam,
> 
> Thank you for the patch.
> 
> On Sat, Jul 10, 2021 at 10:42:40AM +0200, Sam Ravnborg wrote:
> > drm_bridge_funcs includes several duplicated operations as atomic
> > variants has been added over time.
> 
> s/has/have/
> 
> > New bridge drivers shall use the atomic variants - mark the deprecated
> > operations to try to avoid usage in new bridge drivers.
> > 
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Cc: Andrzej Hajda <a.hajda@samsung.com>
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Maxime Ripard <mripard@kernel.org>
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > Cc: David Airlie <airlied@linux.ie>
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > ---
> >  include/drm/drm_bridge.h | 28 ++++++++++++++++++++++++++--
> >  1 file changed, 26 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
> > index 2195daa289d2..6805898d70f5 100644
> > --- a/include/drm/drm_bridge.h
> > +++ b/include/drm/drm_bridge.h
> > @@ -171,6 +171,11 @@ struct drm_bridge_funcs {
> >  	 * signals) feeding it is still running when this callback is called.
> >  	 *
> >  	 * The @disable callback is optional.
> > +	 *
> > +	 * NOTE:
> > +	 *
> > +	 * This is deprecated, do not use!
> > +	 * New drivers shall use &drm_bridge_funcs.atomic_disable.
> >  	 */
> >  	void (*disable)(struct drm_bridge *bridge);
> >  
> > @@ -190,6 +195,11 @@ struct drm_bridge_funcs {
> >  	 * called.
> >  	 *
> >  	 * The @post_disable callback is optional.
> > +	 *
> > +	 * NOTE:
> > +	 *
> > +	 * This is deprecated, do not use!
> > +	 * New drivers shall use &drm_bridge_funcs.atomic_post_disable.
> >  	 */
> >  	void (*post_disable)(struct drm_bridge *bridge);
> >  
> > @@ -213,11 +223,15 @@ struct drm_bridge_funcs {
> >  	 * For atomic drivers the adjusted_mode is the mode stored in
> >  	 * &drm_crtc_state.adjusted_mode.
> >  	 *
> > -	 * NOTE:
> > -	 *
> >  	 * If a need arises to store and access modes adjusted for other
> >  	 * locations than the connection between the CRTC and the first bridge,
> >  	 * the DRM framework will have to be extended with DRM bridge states.
> 
> The DRM framework *has* been extended with DRM bridge states :-) Should
> this be dropped ?
I dropped this while applying.

> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Tnanks!

	Sam