From: Daniel Vetter <daniel@ffwll.ch>
To: "Christian König" <christian.koenig@amd.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
kvm@vger.kernel.org, David Airlie <airlied@linux.ie>,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
Alex Williamson <alex.williamson@redhat.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Alex Deucher <alexander.deucher@amd.com>,
amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
Christoph Hellwig <hch@lst.de>, Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH 1/7] vgaarb: remove VGA_DEFAULT_DEVICE
Date: Tue, 20 Jul 2021 15:50:52 +0200 [thread overview]
Message-ID: <YPbUvIYmu3WfyM2C@phenom.ffwll.local> (raw)
In-Reply-To: <f171831b-3281-5a5a-04d3-2d69cb77f1a2@amd.com>
On Fri, Jul 16, 2021 at 09:14:02AM +0200, Christian König wrote:
> Am 16.07.21 um 08:16 schrieb Christoph Hellwig:
> > The define is entirely unused.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> I'm not an expert for this particular code, but at least of hand everything
> you do here makes totally sense.
>
> Whole series is Acked-by: Christian König <christian.koenig@amd.com>
Care to also push this into drm-misc-next since you looked already?
-Daniel
>
> Regards,
> Christian.
>
> > ---
> > include/linux/vgaarb.h | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h
> > index dc6ddce92066..26ec8a057d2a 100644
> > --- a/include/linux/vgaarb.h
> > +++ b/include/linux/vgaarb.h
> > @@ -42,12 +42,6 @@
> > #define VGA_RSRC_NORMAL_IO 0x04
> > #define VGA_RSRC_NORMAL_MEM 0x08
> > -/* Passing that instead of a pci_dev to use the system "default"
> > - * device, that is the one used by vgacon. Archs will probably
> > - * have to provide their own vga_default_device();
> > - */
> > -#define VGA_DEFAULT_DEVICE (NULL)
> > -
> > struct pci_dev;
> > /* For use by clients */
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2021-07-20 13:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210716061634.2446357-1-hch@lst.de>
[not found] ` <20210716061634.2446357-2-hch@lst.de>
2021-07-16 7:14 ` [PATCH 1/7] vgaarb: remove VGA_DEFAULT_DEVICE Christian König
2021-07-20 13:50 ` Daniel Vetter [this message]
2021-07-20 14:12 ` Christian König
2021-07-21 8:30 ` Christian König
2021-07-16 11:40 ` misc vgaarb cleanups Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPbUvIYmu3WfyM2C@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alex.williamson@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kvm@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox