From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFEAFC07E95 for ; Tue, 20 Jul 2021 17:56:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64C2961029 for ; Tue, 20 Jul 2021 17:56:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64C2961029 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E8D516E4AF; Tue, 20 Jul 2021 17:56:36 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB7146E4AF for ; Tue, 20 Jul 2021 17:56:34 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id d93e7425-e983-11eb-8d1a-0050568cd888; Tue, 20 Jul 2021 17:56:45 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 6314D194B4E; Tue, 20 Jul 2021 19:56:45 +0200 (CEST) Date: Tue, 20 Jul 2021 19:56:27 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Rob Herring Subject: Re: [PATCH] dt-bindings: Remove "status" from schema examples Message-ID: References: <20210720172025.363238-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210720172025.363238-1-robh@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Olivier Moysan , Mateusz Holenko , alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Peter Ujfalusi , ChiYuan Huang , Thierry Reding , Laurent Pinchart , Karol Gugala , linux-rtc@vger.kernel.org, Mauro Carvalho Chehab , Dilip Kota , Wei Xu , Oleksij Rempel , Chen-Yu Tsai , Jakub Kicinski , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Ramesh Shanmugasundaram , Rui Miguel Silva , Mark Brown , "G. Jaya Kumaran" , Robert Marko , Alessandro Zummo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Rob, On Tue, Jul 20, 2021 at 11:20:25AM -0600, Rob Herring wrote: > There's no reason to have "status" properties in examples. "okay" is the > default, and "disabled" turns off some schema checks ('required' > specifically). > > Enabling qca,ar71xx causes a warning, so let's fix the node names: > > Documentation/devicetree/bindings/net/qca,ar71xx.example.dt.yaml: phy@3: '#phy-cells' is a required property > From schema: schemas/phy/phy-provider.yaml I had preferred that the names was fixed in a dedicated patch - to avoid mixing things. But thats just nitpicking, so: Reviewed-by: Sam Ravnborg