From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B7C2C07E95 for ; Tue, 20 Jul 2021 19:56:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1681560234 for ; Tue, 20 Jul 2021 19:56:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1681560234 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 891506E235; Tue, 20 Jul 2021 19:56:14 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1D2606E235 for ; Tue, 20 Jul 2021 19:56:12 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 8ff743a7-e994-11eb-8d1a-0050568cd888; Tue, 20 Jul 2021 19:56:24 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 48CD9194B7A; Tue, 20 Jul 2021 21:56:27 +0200 (CEST) Date: Tue, 20 Jul 2021 21:56:09 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Maxime Ripard Subject: Re: [PATCH 06/10] drm/bridge: panel: Call attach and detach for the panel Message-ID: References: <20210720134525.563936-1-maxime@cerno.tech> <20210720134525.563936-7-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210720134525.563936-7-maxime@cerno.tech> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , dri-devel@lists.freedesktop.org, Jonas Karlman , linux-kernel@vger.kernel.org, Robert Foss , Andrzej Hajda , Thierry Reding , Jernej Skrabec , Thomas Zimmermann , Daniel Vetter , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jul 20, 2021 at 03:45:21PM +0200, Maxime Ripard wrote: > Now that we have additional attach and detach hooks for panels, make > sure that the panel bridge driver calls them when relevant. Combine this with the previous patch as this is again a partial revert of the same patch. Sam > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/bridge/panel.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > index c916f4b8907e..c2249f3fd357 100644 > --- a/drivers/gpu/drm/bridge/panel.c > +++ b/drivers/gpu/drm/bridge/panel.c > @@ -60,6 +60,8 @@ static int panel_bridge_attach(struct drm_bridge *bridge, > struct drm_connector *connector = &panel_bridge->connector; > int ret; > > + drm_panel_attach(panel_bridge->panel); attach can fail... > + > if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR) > return 0; > > @@ -90,6 +92,8 @@ static void panel_bridge_detach(struct drm_bridge *bridge) > struct panel_bridge *panel_bridge = drm_bridge_to_panel_bridge(bridge); > struct drm_connector *connector = &panel_bridge->connector; > > + drm_panel_detach(panel_bridge->panel); > + > /* > * Cleanup the connector if we know it was initialized. > * > -- > 2.31.1