From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0118C4338F for ; Wed, 28 Jul 2021 07:31:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C6E160E78 for ; Wed, 28 Jul 2021 07:31:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7C6E160E78 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D95886E4A2; Wed, 28 Jul 2021 07:31:14 +0000 (UTC) Received: from mx1.smtp.larsendata.com (mx1.smtp.larsendata.com [91.221.196.215]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A2CF6E4A2 for ; Wed, 28 Jul 2021 07:31:13 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx1.smtp.larsendata.com (Halon) with ESMTPS id ccfc103d-ef75-11eb-9082-0050568c148b; Wed, 28 Jul 2021 07:31:19 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 66DB5194B99; Wed, 28 Jul 2021 09:31:33 +0200 (CEST) Date: Wed, 28 Jul 2021 09:31:10 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Anitha Chrisanthus Subject: Re: [PATCH 14/14] drm/kmb: Enable support for fbcon (framebuffer console) Message-ID: References: <20210728003126.1425028-1-anitha.chrisanthus@intel.com> <20210728003126.1425028-14-anitha.chrisanthus@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210728003126.1425028-14-anitha.chrisanthus@intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: edmund.j.dea@intel.com, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Anitha, On Tue, Jul 27, 2021 at 05:31:26PM -0700, Anitha Chrisanthus wrote: > From: Edmund Dea > > Enable support for fbcon (framebuffer console). > The user can initialize fbcon by loading kmb-drm with the parameter > console=1. I do not see the poit of the boot parameter?? Why is it needed here but not in other drivers? > > Signed-off-by: Edmund Dea > Signed-off-by: Anitha Chrisanthus > --- > drivers/gpu/drm/kmb/kmb_drv.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c > index d0de1db03493..d39d004f513a 100644 > --- a/drivers/gpu/drm/kmb/kmb_drv.c > +++ b/drivers/gpu/drm/kmb/kmb_drv.c > @@ -5,6 +5,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -15,6 +16,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -25,7 +27,13 @@ > #include "kmb_dsi.h" > #include "kmb_regs.h" > > -static int kmb_display_clk_enable(struct kmb_drm_private *kmb) > +/* Module Parameters */ > +static bool console; > +module_param(console, bool, 0400); > +MODULE_PARM_DESC(console, > + "Enable framebuffer console support (0=disable [default], 1=on)"); > + > +int kmb_display_clk_enable(struct kmb_drm_private *kmb) kmb_display_clk_enable lost a "static" - it will result in a warning if you build with W=1 > { > int ret = 0; > > @@ -546,6 +554,9 @@ static int kmb_probe(struct platform_device *pdev) > if (ret) > goto err_register; > > + if (console) > + drm_fbdev_generic_setup(&kmb->drm, 32); > + > return 0; > > err_register: > -- > 2.25.1