From: Sam Ravnborg <sam@ravnborg.org>
To: lichenyang <lichenyang@loongson.cn>
Cc: Maxime Ripard <mripard@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Dan Carpenter <dan.carpenter@oracle.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, devel@linuxdriverproject.org,
Huacai Chen <chenhuacai@kernel.org>
Subject: Re: [PATCH v4 2/3] drm/loongson: Add GPIO and I2C driver for loongson drm.
Date: Sun, 1 Aug 2021 22:28:10 +0200 [thread overview]
Message-ID: <YQcD2q7+Dax65lv2@ravnborg.org> (raw)
In-Reply-To: <20210730094148.620768-2-lichenyang@loongson.cn>
Hi lichenyang,
On Fri, Jul 30, 2021 at 05:41:47PM +0800, lichenyang wrote:
> Implement use GPIO and I2C driver to detect connector
> and fetch EDID via DDC.
>
> v3:
> - Change some driver log to the drm_ version.
>
> v2:
> - Optimize the error handling process.
> - Delete loongson_i2c_bus_match and loongson_i2c_add function.
> - Optimize part of the code flow.
>
> Signed-off-by: lichenyang <lichenyang@loongson.cn>
I will return later with more detailed feedback.
One high-level comment is that all the i2c support would be much better
modelled as a bridge. And then you could use the bridge_connector.
Sam
next prev parent reply other threads:[~2021-08-01 20:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210730094148.620768-1-lichenyang@loongson.cn>
2021-08-04 21:12 ` [PATCH v4 1/3] drm/loongson: Add DRM Driver for Loongson 7A1000 bridge chip Sam Ravnborg
[not found] ` <20210730094148.620768-2-lichenyang@loongson.cn>
2021-08-01 20:28 ` Sam Ravnborg [this message]
2021-08-07 9:51 ` [PATCH v4 2/3] drm/loongson: Add GPIO and I2C driver for loongson drm Sam Ravnborg
[not found] ` <20210730094148.620768-3-lichenyang@loongson.cn>
2021-08-07 9:56 ` [PATCH v4 3/3] drm/loongson: Add interrupt driver for LS7A Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQcD2q7+Dax65lv2@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=chenhuacai@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=devel@linuxdriverproject.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=lichenyang@loongson.cn \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox