Re: [PATCH v2] drm/panel: s6d27a1: Add driver for Samsung S6D27A1 display panel

[Sam Ravnborg <sam@ravnborg.org>]

Hi Markuss,
On Tue, Aug 03, 2021 at 08:24:50PM +0300, Markuss Broks wrote:
> This adds a driver for Samsung S6D27A1 display controller and panel.
> This panel is found in the Samsung GT-I8160 mobile phone,
> and possibly some other mobile phones.
> 
> This display needs manufacturer commands to configure it to a working state;
> the commands used in this driver were taken from downstream driver
> by Gareth Phillips; sadly, there is almost no documentation on what they
> actually do.
> 
> This driver re-uses the DBI infrastructure to communicate with the display.
> 
> This driver is heavily based on WideChips WS2401 display controller
> driver by Linus Walleij and on other panel drivers for reference.
> 
> Signed-off-by: Markuss Broks <markuss.broks@gmail.com>

Thnaks for the very quick response.

Please provide a changelog so we can follow what has changed.
Sometimes we revisit patches week and 100 patches later and cannot
remember any feedback.

Like for example (my style):
v3:
  - fixed checkpatch warnings (sam)
  - ...

v2:
  - dropped backlight (sam)
  - dropped kernel-doc (sam)
  - bla bla (someone)

There are many different styles - pick one.



Also two other things.
checkpatch --strict reports a few issues to be fixed:

    total: 0 errors, 5 warnings, 6 checks, 344 lines checked

One of them is a missing binding!

And the patch fails to apply. Please rebase on top of -next or
drm-misc-next.

Thanks in advance!

	Sam