From: Daniel Vetter <daniel@ffwll.ch>
To: Jeevan B <jeevan.b@intel.com>
Cc: dri-devel@lists.freedesktop.org, uma.shankar@intel.com,
kai.vehmanen@linux.intel.com
Subject: Re: [PATCH] Change igt_log level from IGT_LOG_WARN to IGT_LOG_INFO
Date: Wed, 8 Sep 2021 18:47:33 +0200 [thread overview]
Message-ID: <YTjpJTbBwuRfypUu@phenom.ffwll.local> (raw)
In-Reply-To: <20210907183356.11126-1-jeevan.b@intel.com>
On Wed, Sep 08, 2021 at 12:03:56AM +0530, Jeevan B wrote:
> change igt_warn to igt_info when unloading the snd module before
> unbinding i915 until WA is fixed.
>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
Please submit per
https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/blob/master/CONTRIBUTING.md#sending-patches
No one (not even CI) pick up igt patches submitted to dri-devel.
-Daniel
> ---
> tests/core_hotunplug.c | 2 +-
> tests/device_reset.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
> index 2d73e27f..b3661668 100644
> --- a/tests/core_hotunplug.c
> +++ b/tests/core_hotunplug.c
> @@ -164,7 +164,7 @@ static void driver_unbind(struct hotunplug *priv, const char *prefix,
> igt_lsof("/dev/snd");
> igt_skip("Audio is in use, skipping\n");
> } else {
> - igt_warn("Preventively unloaded snd_hda_intel\n");
> + igt_info("Preventively unloaded snd_hda_intel\n");
> }
> }
>
> diff --git a/tests/device_reset.c b/tests/device_reset.c
> index e6a468e6..982ba5ef 100644
> --- a/tests/device_reset.c
> +++ b/tests/device_reset.c
> @@ -201,7 +201,7 @@ static void driver_unbind(struct device_fds *dev)
> igt_lsof("/dev/snd");
> igt_skip("Audio is in use, skipping\n");
> } else {
> - igt_warn("Preventively unloaded snd_hda_intel\n");
> + igt_info("Preventively unloaded snd_hda_intel\n");
> }
> }
>
> --
> 2.19.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
prev parent reply other threads:[~2021-09-08 16:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 18:33 [PATCH] Change igt_log level from IGT_LOG_WARN to IGT_LOG_INFO Jeevan B
2021-09-08 16:47 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTjpJTbBwuRfypUu@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jeevan.b@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox