From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F46DC433F5 for ; Thu, 9 Sep 2021 20:47:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 03A896113A for ; Thu, 9 Sep 2021 20:47:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 03A896113A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 66B1A6E907; Thu, 9 Sep 2021 20:47:45 +0000 (UTC) Received: from mx1.smtp.larsendata.com (mx1.smtp.larsendata.com [91.221.196.215]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4BF8D6E907 for ; Thu, 9 Sep 2021 20:47:42 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx1.smtp.larsendata.com (Halon) with ESMTPS id 25f3738b-11af-11ec-a02a-0050568c148b; Thu, 09 Sep 2021 20:47:29 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 7365C194C27; Thu, 9 Sep 2021 22:47:30 +0200 (CEST) Date: Thu, 9 Sep 2021 22:47:36 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Doug Anderson Cc: Thierry Reding , Rob Herring , Maarten Lankhorst , linux-arm-msm , Bjorn Andersson , Linus W , Daniel Vetter , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Steev Klimaszewski , Thomas Zimmermann , Maxime Ripard , David Airlie , dri-devel , LKML Subject: Re: [PATCH v3 10/16] drm/panel-simple: Non-eDP panels don't need "HPD" handling Message-ID: References: <20210901201934.1084250-1-dianders@chromium.org> <20210901131531.v3.10.I77d7a48df0a6585ef2cc2ff140fbe8f236a9a9f7@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Sep 08, 2021 at 02:10:48PM -0700, Doug Anderson wrote: > Hi, > > On Sun, Sep 5, 2021 at 11:46 AM Sam Ravnborg wrote: > > > > On Wed, Sep 01, 2021 at 01:19:28PM -0700, Douglas Anderson wrote: > > > All of the "HPD" handling added to panel-simple recently was for eDP > > > panels. Remove it from panel-simple now that panel-simple-edp handles > > > eDP panels. The "prepare_to_enable" delay only makes sense in the > > > context of HPD, so remove it too. No non-eDP panels used it anyway. > > > > > > Signed-off-by: Douglas Anderson > > > > Maybe merge this with the patch that moved all the functionality > > from panel-simple to panel-edp? > > Unless you feel strongly about it, I'm going to keep it separate still > in the next version. OK Sam