From: Sam Ravnborg <sam@ravnborg.org>
To: Philip Chen <philipchen@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
swboyd@chromium.org, dianders@chromium.org,
Andrzej Hajda <a.hajda@samsung.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Jonas Karlman <jonas@kwiboo.se>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v5 2/2] drm/bridge: parade-ps8640: Add support for AUX channel
Date: Sat, 18 Sep 2021 22:29:40 +0200 [thread overview]
Message-ID: <YUZMNIYbT7KL3qJR@ravnborg.org> (raw)
In-Reply-To: <20210918102058.v5.2.Ifcb5df5de5b1cead7c99e0f37b044ef5cfc69eda@changeid>
Hi Philip,
On Sat, Sep 18, 2021 at 10:21:17AM -0700, Philip Chen wrote:
> Implement the first version of AUX support, which will be useful as
> we expand the driver to support varied use cases.
>
> Signed-off-by: Philip Chen <philipchen@chromium.org>
Patch is:
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
please consider a few follow-up patches:
1) Replace deprecated drm_bridge_funcs with the _atomic_ variants.
2) Replace the deprecated drm_bridge_chain_pre_enable() with the atomic
variant.
3) Use pr_() and dev_() logging in favour of DRM_ logging.
DRM_ logging is deprecated these days and do not belong in bridge
drivers anyway.
Maxime has a few patches pending for this driver - it would be great if
you could look them up and review them.
Maybe you can get some review in feedback.
Sam
next prev parent reply other threads:[~2021-09-18 20:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 17:21 [PATCH v5 1/2] drm/bridge: parade-ps8640: Use regmap APIs Philip Chen
2021-09-18 17:21 ` [PATCH v5 2/2] drm/bridge: parade-ps8640: Add support for AUX channel Philip Chen
2021-09-18 20:29 ` Sam Ravnborg [this message]
2021-09-20 21:37 ` Philip Chen
2021-09-20 21:42 ` Doug Anderson
2021-09-21 5:20 ` Sam Ravnborg
2021-09-21 16:02 ` Doug Anderson
2021-09-21 18:11 ` Philip Chen
2021-09-18 20:22 ` [PATCH v5 1/2] drm/bridge: parade-ps8640: Use regmap APIs Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUZMNIYbT7KL3qJR@ravnborg.org \
--to=sam@ravnborg.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=philipchen@chromium.org \
--cc=robert.foss@linaro.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox