From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D3B5C433F5 for ; Thu, 23 Sep 2021 13:43:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3228C60F6F for ; Thu, 23 Sep 2021 13:43:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3228C60F6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A2346ED25; Thu, 23 Sep 2021 13:43:31 +0000 (UTC) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B4606ED25 for ; Thu, 23 Sep 2021 13:43:30 +0000 (UTC) Received: by mail-wr1-x430.google.com with SMTP id w29so17295604wra.8 for ; Thu, 23 Sep 2021 06:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=4vvUL3e0KnaoXbHygff1j5G+RP+eVvUFadYzHbYM5yg=; b=bJ/9dqxYZ+yDeJTQt2kNS4H2m8IPsSvr9qIFTk33V/6+ygT7/5ahVdLEEZZSShC60o MiOTpF9eTEClXfv+gm+DVrZ0z+iec6EG+gat7i0Pq0zMXe54QqEzadUAZpOxEV9nqCOu gHIQ0ZGhiDk5ccIVm07xCff/D6+VdOO2mBmy7KHNqBcXdnHEk0HhkUyH+MgTJGhBcSOU hX/HkVPy1WmOzUtMSV8N1MdYMMEfYPQhqvXj0BJMBRU91ov0UAkO20oemTFKzBw0UhvV CctiqQi+Pr4MKa4Nq3NFkHA+ozl5LK8uqW4szRAzXmP2B44jyAurEvNnQvsbpmnGZnoi MzDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=4vvUL3e0KnaoXbHygff1j5G+RP+eVvUFadYzHbYM5yg=; b=smbJIGq1XS2Xc4G+TPC0Wlr3UlS0i9GODqqyXXGWkyt4PefLVpNw5gCOwgPDwi/PBu IOMfAzzgOjmRpr3Z5BcX9i0DepA3iBlsKzRaHYrHdKDWtG/87CIm0I3ROIqYOr+vZ1+B 9CXBbCzBc8WtdUy05IvZUMbGdFajoPu+KcxroF9/HxuKy0FTZb5rqrEPi/Y6aqCBUg2s 6Bjn/Jm5CKFUYXguI46DsCnxPG/TFn40wDxGNjFT4aDiper44Eo6KT4mkQ1fhr+1T/pX Z4e9gFGb9hdTNk3AA9HyVkROKmIJSaA28KumTal+zoGndClGeNkr6AM4fRq4evPOYn/+ 3nTg== X-Gm-Message-State: AOAM5334M/CdX0oA7yfoLi2vf8xT33IRpS84tyi2KjxRHiFOd99dYyFW TfHFnBCd3xOxwhgB9KDXew1OsQ== X-Google-Smtp-Source: ABdhPJyi3UZLScn4v2Ctypt2vtJmPaKpW9SI96CZeGRqpPXO1oNgQczRmKbml0MnljOLuNSCK8caQA== X-Received: by 2002:a5d:5042:: with SMTP id h2mr5145969wrt.57.1632404607073; Thu, 23 Sep 2021 06:43:27 -0700 (PDT) Received: from google.com ([95.148.6.233]) by smtp.gmail.com with ESMTPSA id a3sm5435583wrt.28.2021.09.23.06.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 06:43:26 -0700 (PDT) Date: Thu, 23 Sep 2021 14:43:24 +0100 From: Lee Jones To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Daniel Thompson , Jingoo Han , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] backlight: propagate errors from get_brightness() Message-ID: References: <20210907124751.6404-1-linux@weissschuh.net> <4bb3051e-2550-43c3-afed-d4b00850126e@t-8ch.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4bb3051e-2550-43c3-afed-d4b00850126e@t-8ch.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 23 Sep 2021, Thomas Weißschuh wrote: > On 2021-09-23T10:48+0100, Lee Jones wrote: > > On Tue, 07 Sep 2021, Thomas Weißschuh wrote: > > > > > backlight.h documents "struct backlight_ops->get_brightness()" to return > > > a negative errno on failure. > > > So far these errors have not been handled in the backlight core. > > > This leads to negative values being exposed through sysfs although only > > > positive values are documented to be reported. > > > > > > Signed-off-by: Thomas Weißschuh > > > --- > > > > > > v1: https://lore.kernel.org/dri-devel/20210906215525.15418-1-linux@weissschuh.net/ > > > > > > v1 -> v2: > > > * use dev_err() instead of dev_warn() (Daniel Thompson) > > > * Finish logging format string with newline (Daniel Thompson) > > > * Log errno via dedicated error pointer format (Daniel Thompson) > > > > > > drivers/video/backlight/backlight.c | 22 +++++++++++++++++----- > > > 1 file changed, 17 insertions(+), 5 deletions(-) > > > > Applied, thanks. > > Hi Lee, > > thanks! > > Also I'm sorry about my nagging before. No worries. > I was not aware you were on vacation and saw you respond to other mails. They were in the queue before this one. I had hundreds of emails to get through on my return! -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog