From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EDE8C433F5 for ; Wed, 6 Oct 2021 02:08:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA3EF61207 for ; Wed, 6 Oct 2021 02:08:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA3EF61207 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F0B956ECB8; Wed, 6 Oct 2021 02:08:51 +0000 (UTC) Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by gabe.freedesktop.org (Postfix) with ESMTPS id E50206ECB3 for ; Wed, 6 Oct 2021 02:08:49 +0000 (UTC) Received: by mail-oi1-x22e.google.com with SMTP id t4so71030oie.5 for ; Tue, 05 Oct 2021 19:08:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lYqbd1yY6Vt/MStunvcBDmbeftnynuSmElbE65yJeuI=; b=GC6d96YWZxDnlnByKPE8fzKDBgpe+/UipmMF6p4IzkEANqw1A+OhrXdDLSPEZdgDy4 am8AsWG52xoFc6BD1SSQypkjO8/pMZdsimyMa0CTKwTOCVB+58kihH0X4CilBV7FzGrF WX+AM7FGM1t8QjqF2kVBwQD9XAkawVs5tMe1myGfh2X0jlwxR1lHFmp9rcMmyVJus8aw UeUQPVSmfb/2fCUwCtXoCf9AWZy/mAxrPsHgnJXkKS4gxCFRGBQ470PbFnKB6H9COVJd wbYZ9vaA9bqwPHC45Dj+ztPNh5EvwRv0UkZjFKEBmxNs6zXDyVgpTk2NuMug5pg2dXW6 SpEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lYqbd1yY6Vt/MStunvcBDmbeftnynuSmElbE65yJeuI=; b=o9wu+L3TfxZp4xNmQEichN38qVZRXBXaLDndPyvwp1DH2zv5w85ab2gPKOHZMq698r XpKo0ZCCebRlQ4pbU77H0D0gomzQTzJhel6atAUOxQ0CRXTbNuxTv1JI0fMnHghl6X4j 9Jtv1ZCLrb2De6v97XU8LFX5e5xfp0G43f5dbb70W5cZeZ9KcrXgM3GqXrel5qknESKA PzKi22IOKTD183Wcn3PQi6SAqvI3/K44vOTh4XaqKI5omTlp+MlCZiwFXFdoX3p+XOiS nMHcUQqUlqxZujhZfJ1BiowOcmV476bDRJwdMO+gdPuoHSzW2K/vPlTfsGVzgxYAGQb8 TwHg== X-Gm-Message-State: AOAM531dP3Rjr6PxNKa/d2qbMTw3lV1q0ggU1fvqB2s9UFivtvvuu11Q pyHQhjdFaxm2mazXv3D8hTGIYw== X-Google-Smtp-Source: ABdhPJwOAzvNXUWrQOMZZ6Pn52U6g6WPpbGpk9AzF5O1hc8wZyZsEDHPz1VOQo1RF640zOdBhAsitA== X-Received: by 2002:a05:6808:a99:: with SMTP id q25mr5117219oij.162.1633486128519; Tue, 05 Oct 2021 19:08:48 -0700 (PDT) Received: from ripper ([2600:1700:a0:3dc8:205:1bff:fec0:b9b3]) by smtp.gmail.com with ESMTPSA id l23sm3535076otk.21.2021.10.05.19.08.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 19:08:48 -0700 (PDT) Date: Tue, 5 Oct 2021 19:10:29 -0700 From: Bjorn Andersson To: khsieh@codeaurora.org Cc: Stephen Boyd , Abhinav Kumar , Daniel Vetter , David Airlie , Dmitry Baryshkov , Rob Clark , Sean Paul , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sankeerth Billakanti Subject: Re: [PATCH] drm/msm/dp: Shorten SETUP timeout Message-ID: References: <20211005023750.2037631-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue 05 Oct 16:04 PDT 2021, khsieh@codeaurora.org wrote: > On 2021-10-05 15:36, Stephen Boyd wrote: > > Quoting Bjorn Andersson (2021-10-05 14:40:38) > > > On Tue 05 Oct 11:45 PDT 2021, Stephen Boyd wrote: > > > > > > > Quoting Bjorn Andersson (2021-10-04 19:37:50) > > > > > Found in the middle of a patch from Sankeerth was the reduction of the > > > > > INIT_SETUP timeout from 10s to 100ms. Upon INIT_SETUP timeout the host > > > > > is initalized and HPD interrupt start to be serviced, so in the case of > > > > > eDP this reduction improves the user experience dramatically - i.e. > > > > > removes 9.9s of bland screen time at boot. > > > > > > > > > > Suggested-by: Sankeerth Billakanti > > > > > Signed-off-by: Bjorn Andersson > > > > > --- > > > > > > > > Any Fixes tag? BTW, the delay design is pretty convoluted. I had to go > > > > re-read the code a couple times to understand that it's waiting 100ms > > > > times the 'delay' number. Whaaaaat? > > > > > > > > > > I assume you're happy with the current 10s delay on the current > > > devices, so I don't think we should push for this to be backported. > > > I have no need for it to be backported on my side at least. > > > > > > > Sure. Fixes tag != backported to stable trees but it is close. > > > > > > Reviewed-by: Stephen Boyd > > > > dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 1); <== to 100ms > > This patch will prevent usb3 from working due to dp driver initialize phy > earlier than usb3 which cause timeout error at power up usb3 phy when both > edp and dp are enabled. Can you please help me understand what you mean here, I use this on my sc8180x with both eDP and USB-C/DP right now. What is it that doesn't work? Or am I just lucky in some race condition? Thanks, Bjorn > I had prepared a patch (drm/msm/dp: do not initialize combo phy until plugin > interrupt) to fix this problem. > Unfortunately, my patch is depend on Bjorn's patch (PATCH v3 3/5] > drm/msm/dp: Support up to 3 DP controllers). > I will submit my patch for review once Bjorn's patches merged in. > Therefore I would think this patch should go after both Bjorn's patches and > my patch. > > >