From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C021C433FE for ; Wed, 6 Oct 2021 10:52:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A908610C7 for ; Wed, 6 Oct 2021 10:52:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0A908610C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 444146ED95; Wed, 6 Oct 2021 10:52:45 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A15C6ED83; Wed, 6 Oct 2021 10:52:43 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 50DF6610C7; Wed, 6 Oct 2021 10:52:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633517563; bh=V9qmdHUZA/980yayysl1P0r8HfySgR/QYHEMF/9Epok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QuvRMNmIvEVDpKW6QLLfnJF3PSyj247P9OYMcxvJ7o24xfkR0FTG/m+/Z156P5S/A WBySWuKlyvcC8dapMxwOVLK8budbIjtoeTlGrKbf8zqntQ4EDqkbV/HvNAHZYVskrP RDczcxvE664yS2qx0IY2dAODGWEtZciySaEmpwCZ9tjjLW87ghsqWqVqE2hoZImqkk 24T+4CisJX2mYKzoGDd128Yhh939ZqlUnC1g34hHA9VyYOoyWlXDqwplp5j9/7+Y/B 754KPlCOgZ/pKMWKIWWnFq3Zw2q01m59+LSI2I7aT5yJyLKGqoV/jwYN2/76tbruHl ioFRi+1FALu/A== Date: Wed, 6 Oct 2021 16:22:39 +0530 From: Vinod Koul To: abhinavk@codeaurora.org Cc: Rob Clark , Jonathan Marek , Jeffrey Hugo , David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson , dri-devel@lists.freedesktop.org, Daniel Vetter , Dmitry Baryshkov , freedreno@lists.freedesktop.org, Sumit Semwal Subject: Re: [Freedreno] [PATCH 05/11] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog Message-ID: References: <20210715065203.709914-1-vkoul@kernel.org> <20210715065203.709914-6-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 02-08-21, 16:29, abhinavk@codeaurora.org wrote: > On 2021-07-14 23:51, Vinod Koul wrote: > > This add SDM845 DSC blocks into hw_catalog > /add --> adds > > > > Signed-off-by: Vinod Koul > > --- > > Changes since RFC: > > - use BIT values from MASK > > > > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 22 +++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > > b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > > index b569030a0847..b45a08303c99 100644 > > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > > @@ -40,6 +40,8 @@ > > > > #define PINGPONG_SDM845_MASK BIT(DPU_PINGPONG_DITHER) > > > > +#define DSC_SDM845_MASK BIT(1) > agree with dmitry again : > https://patchwork.freedesktop.org/patch/444072/?series=90413&rev=2 > this is unused. you can use .features = 0 Yes I have updated that -- ~Vinod