From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A208BC433F5 for ; Wed, 6 Oct 2021 10:50:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6DFF260FC4 for ; Wed, 6 Oct 2021 10:50:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6DFF260FC4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 719336E50C; Wed, 6 Oct 2021 10:50:36 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D1386E50C; Wed, 6 Oct 2021 10:50:35 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3965A61039; Wed, 6 Oct 2021 10:50:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633517435; bh=v8y1N4gIhukedV+p7pkwbFPb5wyssQGcXOteiYdVAs0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DSY2cZ3YrqRxq8WBCGCQbM8+YMm1eFDmDfYPtcHVk7LSQSFtl1xhEnNh4P92pBXUn KXHLotS9hUcjB9439HF+g9ewZcAXF1qa0QPISFqmY4PYy5A3fXI+dWZIPJUx1aFx/F 0fNRTQOHjPu9cX2HuwDRvlU7HuAb3tzs3tOmgNWZrlQ0l5bCwDDoe8Ngqj2v3Y1L0F xB4PJZJrGoqT7VvU8vkIysdTSbXv9IFVCQeU3foA/7vUI2SNxbOvj56AhY0mme9p+c HKOe/Ru7Xsn2F9S6eon/GiBDI72BzGODCo2h9tEcO3GeR5p+9erlVf86BYiXunhYn/ RFfLp+ZVOBuTQ== Date: Wed, 6 Oct 2021 16:20:30 +0530 From: Vinod Koul To: Dmitry Baryshkov Cc: Rob Clark , linux-arm-msm@vger.kernel.org, Bjorn Andersson , David Airlie , Daniel Vetter , Jonathan Marek , Abhinav Kumar , Jeffrey Hugo , Sumit Semwal , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH 05/11] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog Message-ID: References: <20210715065203.709914-1-vkoul@kernel.org> <20210715065203.709914-6-vkoul@kernel.org> <927826ce-eae5-0089-6874-eb14d8e16169@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <927826ce-eae5-0089-6874-eb14d8e16169@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 29-07-21, 23:25, Dmitry Baryshkov wrote: > On 15/07/2021 09:51, Vinod Koul wrote: > > This add SDM845 DSC blocks into hw_catalog > > > > Signed-off-by: Vinod Koul > > --- > > Changes since RFC: > > - use BIT values from MASK > > > > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 22 +++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > > index b569030a0847..b45a08303c99 100644 > > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > > @@ -40,6 +40,8 @@ > > #define PINGPONG_SDM845_MASK BIT(DPU_PINGPONG_DITHER) > > +#define DSC_SDM845_MASK BIT(1) > > + > > This does not seem used. You can pass (0) as the feature mask. Yes fixed -- ~Vinod