dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Simon Ser <contact@emersion.fr>
Cc: dri-devel@lists.freedesktop.org,
	Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>,
	Daniel Vetter <daniel@ffwll.ch>,
	Pekka Paalanen <ppaalanen@gmail.com>,
	Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH] drm/connector: refer to CTA-861-G in the "content type" prop docs
Date: Mon, 4 Oct 2021 12:22:17 +0300	[thread overview]
Message-ID: <YVrHyUJPQg731vub@intel.com> (raw)
In-Reply-To: <20211004091236.82010-1-contact@emersion.fr>

On Mon, Oct 04, 2021 at 09:12:50AM +0000, Simon Ser wrote:
> The KMS documentation doesn't say much about the meaning of each
> content type. Add a reference to the specification defining them.
> 
> Signed-off-by: Simon Ser <contact@emersion.fr>
> Cc: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Pekka Paalanen <ppaalanen@gmail.com>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> ---
>  drivers/gpu/drm/drm_connector.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index 3bc782b630b9..79d8163686cd 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -1397,6 +1397,8 @@ EXPORT_SYMBOL(drm_connector_attach_dp_subconnector_property);
>   *	Game:
>   *		Content type is game
>   *
> + *	The meaning of each content type is defined in CTA-861-G table 15.
> + *

A bit annoying to have to refer to an external spec, but copy pasting
the whole thing here seems a bit questionable.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>   *	Drivers can set up this property by calling
>   *	drm_connector_attach_content_type_property(). Decoding to
>   *	infoframe values is done through drm_hdmi_avi_infoframe_content_type().
> -- 
> 2.33.0
> 

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2021-10-04  9:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04  9:12 [PATCH] drm/connector: refer to CTA-861-G in the "content type" prop docs Simon Ser
2021-10-04  9:22 ` Ville Syrjälä [this message]
2021-10-04  9:26   ` Simon Ser
2021-10-05  7:36 ` Pekka Paalanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVrHyUJPQg731vub@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=contact@emersion.fr \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=linkmauve@linkmauve.fr \
    --cc=ppaalanen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox