Re: [RFC PATCH] drm: Increase DRM_OBJECT_MAX_PROPERTY by 18.

[Daniel Vetter <daniel@ffwll.ch>]

On Thu, Oct 14, 2021 at 03:47:31PM +0200, Sebastian Andrzej Siewior wrote:
> On 2021-10-14 15:21:22 [+0200], Daniel Vetter wrote:
> > On Wed, Oct 13, 2021 at 07:35:48PM +0200, Sebastian Andrzej Siewior wrote:
> > > c7fcbf2513973 -> does not boot
> > > c7fcbf2513973 + 2f425cf5242a0 -> boots, 18 x DRM_OBJECT_MAX_PROPERTY
> > > 6f11f37459d8f -> boots, 0 x DRM_OBJECT_MAX_PROPERTY
> > > 6f11f37459d8f + 2f425cf5242a0 -> boots, 18 x DRM_OBJECT_MAX_PROPERTY
> > 
> > Just to check, you've built 6f11f37459d8f, and then you cherry-picked
> > 2f425cf5242a0 on top (not merged), and that already got you the warning
> > flood?
> 
> Correct.
> 
> > I'm probably blind, but I'm really not seeing where this pile of
> > properties is coming from. Can you pls also boot with drm.debug=0xe and
> > attach full dmesg? Plus your .config please.
> 
> attached. dmesg.txt is 6f11f37459d8f and the other is 6f11f37459d8f +
> 2f425cf5242a0.

Ah dmesg help me understand what's going on. Does the below patch help? If
it's this one that would also explain why intel CI hasn't hit it - it's a
leak between tests and we run them all individually instead of once at
boot-up.

Cheers, Daniel

diff --git a/drivers/gpu/drm/selftests/test-drm_damage_helper.c b/drivers/gpu/drm/selftests/test-drm_damage_helper.c
index 1c19a5d3eefb..8d8d8e214c28 100644
--- a/drivers/gpu/drm/selftests/test-drm_damage_helper.c
+++ b/drivers/gpu/drm/selftests/test-drm_damage_helper.c
@@ -30,6 +30,7 @@ static void mock_setup(struct drm_plane_state *state)
 	mock_device.driver = &mock_driver;
 	mock_device.mode_config.prop_fb_damage_clips = &mock_prop;
 	mock_plane.dev = &mock_device;
+	mock_obj_props.count = 0;
 	mock_plane.base.properties = &mock_obj_props;
 	mock_prop.base.id = 1; /* 0 is an invalid id */
 	mock_prop.dev = &mock_device;
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch