From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A54FDC433EF for ; Sat, 9 Oct 2021 17:10:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 040C560F4A for ; Sat, 9 Oct 2021 17:10:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 040C560F4A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F0BC76E1DE; Sat, 9 Oct 2021 17:10:19 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id C656B6E1DE for ; Sat, 9 Oct 2021 17:10:18 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id be3704b0-2923-11ec-ac3c-0050568cd888; Sat, 09 Oct 2021 17:10:03 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 8BE95194B00; Sat, 9 Oct 2021 19:10:04 +0200 (CEST) Date: Sat, 9 Oct 2021 19:10:14 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Dmitry Baryshkov Cc: Thierry Reding , David Airlie , Daniel Vetter , Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: Fix build [Was: [PATCH 2/2] drm/panel: Add support for Sharp LS060T1SX01 panel] Message-ID: References: <20210808035053.58074-1-dmitry.baryshkov@linaro.org> <20210808035053.58074-2-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Oct 09, 2021 at 07:07:46PM +0200, Sam Ravnborg wrote: > Applied this but forgot to commit the build fix: > > commit 1ae669fe083fda99e465ae6ab2c533658bdb846e > Author: Sam Ravnborg > Date: Sat Oct 9 19:02:48 2021 +0200 > > drm/panel: sharp-ls060t1sx01: fix build > > Update MIPI_DSI_MODE_EOT_PACKET to the new MIPI_DSI_MODE_NO_EOT_PACKET > variant. > This fixes the build - I had not committed the fix (blush). > > Signed-off-by: Sam Ravnborg > Fixes: 223cce88a926 ("drm/panel: Add support for Sharp LS060T1SX01 panel") > Cc: Dmitry Baryshkov > > diff --git a/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c b/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c > index 1049810d1f10..ed5f28c8c90b 100644 > --- a/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c > +++ b/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c > @@ -275,7 +275,7 @@ static int sharp_ls060_probe(struct mipi_dsi_device *dsi) > dsi->lanes = 4; > dsi->format = MIPI_DSI_FMT_RGB888; > dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST | > - MIPI_DSI_MODE_EOT_PACKET | > + MIPI_DSI_MODE_NO_EOT_PACKET | > MIPI_DSI_CLOCK_NON_CONTINUOUS; > > drm_panel_init(&ctx->panel, dev, &sharp_ls060_panel_funcs, Seems I need more coffee, this patch should never have hit drm-misc-next. I will revert it. Sam