From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA3DCC4332F for ; Wed, 13 Oct 2021 12:03:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EDBC6109E for ; Wed, 13 Oct 2021 12:03:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7EDBC6109E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4E99F6E0DB; Wed, 13 Oct 2021 12:03:05 +0000 (UTC) Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by gabe.freedesktop.org (Postfix) with ESMTPS id A72BC89B18 for ; Wed, 13 Oct 2021 12:03:03 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id y3so7610568wrl.1 for ; Wed, 13 Oct 2021 05:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tLMtiaHO43y3nZZshtTm1xT7kRLw5WpBRX2eSuhKUj0=; b=kmZj81uy861bpMjBye/XcqKh/h82Uru7HCl1UBwZFDOfLWJGjWyTgPcN2aeCNeYBiX PSuIDKfNf4n9hisq0MELwZvUOMD8lADDtBH2rvUIPR0NO+ccxQ4z2Th6hA0x3zQHAjTp uhcJRTT4XiugY7PmzbCR8/6rNTOz4CH595lQo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tLMtiaHO43y3nZZshtTm1xT7kRLw5WpBRX2eSuhKUj0=; b=XGIJnF1kmDsQZfg7NLT5DvzBVTaPGXag/ymwruUqTgCD/LjLWL/k0g5a8YNnvqBE1E 1bbzT80VF237+1AVTru7fGMk/4NiK169DESUY0AVrIinO9xUt1VDQujInT+Kpkne59zO OvQkVhWsfS41XpgRkz/2c9Rb9nETLZr4yE/lqNcGF3mHOJvOZ5ZzoHbWn+Fpkr5H2UqX SiF0e2c3MVOstlC/HexhOQye4dN+O2Z1NgMFsJ57qETbN0BH/LnO3nmQXKWqDkQBqmNK y/GGhLTvWy3Y9tTSZiLgwB10JvjrU0nIGATIq1DpHeHTOYl2sdKf8YBtPX7VUXp7ah51 /YfA== X-Gm-Message-State: AOAM533ILPhXjOMaKKnBeFTQJEsVzKldXr+cB7woqy0CfR9CDpF+euKj +9gy0VA41hcsRaKSYEbH9Un3AN7wObXE/g== X-Google-Smtp-Source: ABdhPJx3MXAtTuNLmxeCU0+cNNDo/Nq15XI7ieE88hvub+RRcIIIJu/idT8/5brRjKh4b79q5KKBLg== X-Received: by 2002:a1c:7e87:: with SMTP id z129mr12089968wmc.75.1634126582210; Wed, 13 Oct 2021 05:03:02 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id w11sm4949814wmc.44.2021.10.13.05.03.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 05:03:01 -0700 (PDT) Date: Wed, 13 Oct 2021 14:02:59 +0200 From: Daniel Vetter To: Sebastian Andrzej Siewior Cc: dri-devel@lists.freedesktop.org, Maarten Lankhorst , intel-gfx@lists.freedesktop.org, Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Thomas Gleixner Subject: Re: [RFC PATCH] drm: Increase DRM_OBJECT_MAX_PROPERTY by 18. Message-ID: References: <20211005065151.828922-1-bigeasy@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211005065151.828922-1-bigeasy@linutronix.de> X-Operating-System: Linux phenom 5.10.0-8-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Oct 05, 2021 at 08:51:51AM +0200, Sebastian Andrzej Siewior wrote: > The warning poped up, it says it increase it by the number of occurrence. > I saw it 18 times so here it is. > It started to up since commit > 2f425cf5242a0 ("drm: Fix oops in damage self-tests by mocking damage property") > > Increase DRM_OBJECT_MAX_PROPERTY by 18. > > Signed-off-by: Sebastian Andrzej Siewior Which driver where? Whomever added that into upstream should also have realized this (things will just not work) and include it in there. So if things are tested correctly this should be part of a larger series to add these 18 props somewhere. Also maybe we should just dynamically allocate this array if people have this many properties on their objects. -Daniel > --- > > I have no idea whether this is correct or just a symptom of another > problem. This has been observed with i915 and full debug. > > include/drm/drm_mode_object.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/drm/drm_mode_object.h b/include/drm/drm_mode_object.h > index c34a3e8030e12..1e5399e47c3a5 100644 > --- a/include/drm/drm_mode_object.h > +++ b/include/drm/drm_mode_object.h > @@ -60,7 +60,7 @@ struct drm_mode_object { > void (*free_cb)(struct kref *kref); > }; > > -#define DRM_OBJECT_MAX_PROPERTY 24 > +#define DRM_OBJECT_MAX_PROPERTY 42 > /** > * struct drm_object_properties - property tracking for &drm_mode_object > */ > -- > 2.33.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch