From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BF9CC433EF for ; Fri, 15 Oct 2021 18:16:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A17061073 for ; Fri, 15 Oct 2021 18:16:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0A17061073 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 55E1D6E158; Fri, 15 Oct 2021 18:16:29 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id CDB5D6E158 for ; Fri, 15 Oct 2021 18:16:27 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 07a3ea80-2de4-11ec-ac3c-0050568cd888; Fri, 15 Oct 2021 18:16:34 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id B02B0194B3E; Fri, 15 Oct 2021 20:16:32 +0200 (CEST) Date: Fri, 15 Oct 2021 20:16:23 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Sebastian Reichel Cc: Qing Wang , Thierry Reding , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm: panel: replace snprintf in show functions with sysfs_emit Message-ID: References: <1634280490-4429-1-git-send-email-wangqing@vivo.com> <20211015111139.ozarnvcdxscbaqv4@earth.universe> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015111139.ozarnvcdxscbaqv4@earth.universe> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Qing and Sebastian. On Fri, Oct 15, 2021 at 01:11:39PM +0200, Sebastian Reichel wrote: > Hi, > > On Thu, Oct 14, 2021 at 11:48:10PM -0700, Qing Wang wrote: > > show() must not use snprintf() when formatting the value to be > > returned to user space. > > > > Fix the following coccicheck warning: > > drivers/gpu/drm/panel/panel-dsi-cm.c:251: WARNING: use scnprintf or sprintf. > > drivers/gpu/drm/panel/panel-dsi-cm.c:271: WARNING: use scnprintf or sprintf. > > > > Use sysfs_emit instead of scnprintf or sprintf makes more sense. > > > > Signed-off-by: Qing Wang > > --- > > The patch subject could be more specific (this updates just one panel driver). > Otherwise: > > Reviewed-by: Sebastian Reichel Updated the patch subject and applied the patch to drm-misc-next. It will show up in -next in 1-2 weeks. Sam