From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2043C433EF for ; Fri, 12 Nov 2021 14:47:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D95861054 for ; Fri, 12 Nov 2021 14:47:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8D95861054 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2C7B189E0D; Fri, 12 Nov 2021 14:47:56 +0000 (UTC) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C48E6E047 for ; Fri, 12 Nov 2021 14:47:54 +0000 (UTC) Received: by mail-ot1-f52.google.com with SMTP id a23-20020a9d4717000000b0056c15d6d0caso7030940otf.12 for ; Fri, 12 Nov 2021 06:47:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MqpVUsLYNqsJjO4ImeTejjx8SUZnfDjbhJPSiiUyJOQ=; b=Wiwjnds4Tey/cJdAo0Iy15WP1zLRYUAtnuaPzlHH4rH2W5SnQUGixJekqUPY4kjmy4 C0pRemEGt+8dy61lu1CimbKIGU8OJ/MGV7rUPpMTWoa71y1RmjzAOtXpB7yPPacAkXIR IBnTflCKGaLqpYF84ubkF9j/X8E0QzvgmJJX4XmDijibml9xvJaDWj8sNqK6vTTnTJQ0 3BgrHBFh2LvgD1oIY2yHoZAqLmUAG+U3HNb7bkSMaPSRbzj43bSi6jAwGt15i6xyW3GQ 4VebnTjGo6ea18CiIw3SAcoh7xw6+4PMCwQAetHJut76i8ORev+Ej15pOZICpNJVS3Fl 5oXg== X-Gm-Message-State: AOAM53214g+GWsl/jGX+Wd5NTRKKHP0LyLUmu/7xjmpY58pz0XjxaNDI HuHjpyClj3xYw8yXLieH8w== X-Google-Smtp-Source: ABdhPJzDQAhXlkjwRvi5urW+7d003gcUAFjnSG2AHX4B3iXy467gNUrRe93n1Idba1w8d58aLwaeMw== X-Received: by 2002:a9d:326:: with SMTP id 35mr11139198otv.41.1636728473571; Fri, 12 Nov 2021 06:47:53 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id g26sm1280650ots.25.2021.11.12.06.47.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 06:47:52 -0800 (PST) Received: (nullmailer pid 2736205 invoked by uid 1000); Fri, 12 Nov 2021 14:47:46 -0000 Date: Fri, 12 Nov 2021 08:47:46 -0600 From: Rob Herring To: "H. Nikolaus Schaller" Subject: Re: [PATCH v6 3/8] dt-bindings: display: Add ingenic,jz4780-dw-hdmi DT Schema Message-ID: References: <70f2abb5277369721cb352eb50daa407bee3fd04.1636573413.git.hns@goldelico.com> <1636642646.871896.3774079.nullmailer@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1636642646.871896.3774079.nullmailer@robh.at.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Paul Boddie , Geert Uytterhoeven , Neil Armstrong , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Paul Cercueil , Laurent Pinchart , Miquel Raynal , Sam Ravnborg , Jernej Skrabec , linux-mips@vger.kernel.org, devicetree@vger.kernel.org, Kees Cook , Jonas Karlman , Mark Brown , Maxime Ripard , letux-kernel@openphoenux.org, Ezequiel Garcia , Thomas Bogendoerfer , Liam Girdwood , Robert Foss , "Eric W. Biederman" , Hans Verkuil Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Nov 11, 2021 at 08:57:26AM -0600, Rob Herring wrote: > On Wed, 10 Nov 2021 20:43:28 +0100, H. Nikolaus Schaller wrote: > > From: Sam Ravnborg > > > > Add DT bindings for the hdmi driver for the Ingenic JZ4780 SoC. > > Based on .txt binding from Zubair Lutfullah Kakakhel > > > > We also add add generic ddc-i2c-bus to synopsys,dw-hdmi.yaml > > > > Signed-off-by: Sam Ravnborg > > Signed-off-by: H. Nikolaus Schaller > > Cc: Rob Herring > > Cc: devicetree@vger.kernel.org > > --- > > .../display/bridge/synopsys,dw-hdmi.yaml | 3 + > > .../bindings/display/ingenic-jz4780-hdmi.yaml | 76 +++++++++++++++++++ This goes in display/bridge/. And use compatible string for the file name: ingenic,jz4780-hdmi.yaml > > 2 files changed, 79 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml:36:5: [warning] wrong indentation: expected 2 but found 4 (indentation) > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.example.dt.yaml: hdmi@10180000: 'clock-names', 'ddc-i2c-bus', 'interrupt-parent', 'interrupts', 'reg' do not match any of the regexes: 'pinctrl-[0-9]+' > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/ingenic-jz4780-hdmi.yaml I think you need to use 'unevaluatedPropertes' instead of 'additionalProperties' if you are getting these properties from synopsys,dw-hdmi.yaml. Rob