From: Daniel Vetter <daniel@ffwll.ch>
To: Harry Wentland <harry.wentland@amd.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
"Michel Dänzer" <michel@daenzer.net>,
"Christian König" <christian.koenig@amd.com>,
"Kazlauskas, Nicholas" <Nicholas.Kazlauskas@amd.com>
Subject: Re: Questions about KMS flip
Date: Fri, 5 Nov 2021 19:13:47 +0100 [thread overview]
Message-ID: <YYV0W1CxT5torU7u@phenom.ffwll.local> (raw)
In-Reply-To: <5c242319-ade3-5621-6429-f77b17c34de5@amd.com>
On Thu, Nov 04, 2021 at 12:44:34PM -0400, Harry Wentland wrote:
> +Nick
>
> It looks to be the old drm_plane_state->fb holds that reference. See dm_plane_helper_cleanup_fb() in amdgpu_dm.c.
Yup plane state holds reference for its entire existing (well this holds
in general as design principle for atomic state structs, just makes life
easier). And the plane state is guaranteed to exist from when we first pin
(prepare_fb plane hook) to when it's getting unpinned (cleanup_fb plane
hook).
Out of curiosity, what's blowing up?
-Daniel
>
> Harry
>
> On 2021-11-04 08:51, Christian König wrote:
> > Hi guys,
> >
> > adding the usual suspects which might know that of hand: When we do a KMS page flip, who keeps the reference to the BO while it is scanned out?
> >
> > We are running into warning backtraces from TTM which look more than odd.
> >
> > Thanks,
> > Christian.
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2021-11-05 18:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 12:51 Questions about KMS flip Christian König
2021-11-04 16:44 ` Harry Wentland
2021-11-05 12:20 ` Ville Syrjälä
2021-11-05 18:13 ` Daniel Vetter [this message]
2021-11-08 7:44 ` Christian König
2021-11-08 14:59 ` Daniel Vetter
2021-11-10 10:18 ` Christian König
2021-11-10 13:26 ` Daniel Vetter
2021-11-12 12:47 ` Christian König
2021-11-12 14:29 ` Michel Dänzer
2021-11-12 14:30 ` Michel Dänzer
2021-11-12 15:03 ` Christian König
2021-11-12 16:10 ` Michel Dänzer
2021-11-15 6:41 ` Lang Yu
2021-11-15 8:38 ` Michel Dänzer
2021-11-15 9:04 ` Lang Yu
2021-11-15 9:49 ` Michel Dänzer
2021-11-15 11:31 ` Lang Yu
2021-11-15 12:04 ` Michel Dänzer
2021-11-16 3:27 ` Lang Yu
2021-11-16 7:14 ` Christian König
2021-11-16 8:00 ` Lang Yu
2021-11-16 8:09 ` Christian König
2021-11-16 14:10 ` Alex Deucher
2021-11-16 14:50 ` Michel Dänzer
2021-11-15 7:25 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYV0W1CxT5torU7u@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Nicholas.Kazlauskas@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox