From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE396C433F5 for ; Mon, 15 Nov 2021 09:19:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7362E61B2B for ; Mon, 15 Nov 2021 09:19:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7362E61B2B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B0CC06EC0F; Mon, 15 Nov 2021 09:19:12 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 609936EC0F for ; Mon, 15 Nov 2021 09:19:11 +0000 (UTC) Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C9F1E9CA; Mon, 15 Nov 2021 10:19:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1636967950; bh=DyMiGF8dYpIO7sFrfkTrEHyV1KL7y6BUoG/PpdzWVzI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IazgGZ0N2QKgbD2xiliOgSKM/Wh6Ku2e/ttwUbC+gF1dv3N9Q27dBA+K+YHkhhn3f 128fjkKnCXSOo6RM9eqPTMGb4Rdwc+4oI3NFochnUeHBJsqlLB6JXS7U5djKpnhGrr 6nHRXJmkdxcDwrNkgsOFzaGTd+Zdnc73MAIEaL64= Date: Mon, 15 Nov 2021 11:18:47 +0200 From: Laurent Pinchart To: Arnd Bergmann Subject: Re: [PATCH 11/11] dmaengine: remove slave_id config field Message-ID: References: <20211115085403.360194-1-arnd@kernel.org> <20211115085403.360194-12-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211115085403.360194-12-arnd@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Bjorn Andersson , linux-tegra@vger.kernel.org, Thierry Reding , linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, Robert Jarzmik , Chunyan Zhang , linux-staging@lists.linux.dev, Michal Simek , Jon Hunter , Andy Gross , bcm-kernel-feedback-list@broadcom.com, linux-serial@vger.kernel.org, Orson Zhai , Nicolas Saenz Julienne , Arnd Bergmann , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, Mark Brown , linux-rpi-kernel@lists.infradead.org, Jaroslav Kysela , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, Scott Branden , Hyun Kwon , Greg Kroah-Hartman , linux-mmc@vger.kernel.org, Takashi Iwai , linux-kernel@vger.kernel.org, Vinod Koul , Laxman Dewangan , Baolin Wang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Arnd, Thank you for the patch. On Mon, Nov 15, 2021 at 09:54:03AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > All references to the slave_id field have been removed, so > remove the field as well to prevent new references from > creeping in again. A rationale to explain why the slave_id field shouldn't be used would be nice. > Signed-off-by: Arnd Bergmann Reviewed-by: Laurent Pinchart > --- > include/linux/dmaengine.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h > index 9000f3ffce8b..0349b35235e6 100644 > --- a/include/linux/dmaengine.h > +++ b/include/linux/dmaengine.h > @@ -418,9 +418,6 @@ enum dma_slave_buswidth { > * @device_fc: Flow Controller Settings. Only valid for slave channels. Fill > * with 'true' if peripheral should be flow controller. Direction will be > * selected at Runtime. > - * @slave_id: Slave requester id. Only valid for slave channels. The dma > - * slave peripheral will have unique id as dma requester which need to be > - * pass as slave config. > * @peripheral_config: peripheral configuration for programming peripheral > * for dmaengine transfer > * @peripheral_size: peripheral configuration buffer size > @@ -448,7 +445,6 @@ struct dma_slave_config { > u32 src_port_window_size; > u32 dst_port_window_size; > bool device_fc; > - unsigned int slave_id; > void *peripheral_config; > size_t peripheral_size; > }; -- Regards, Laurent Pinchart