From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5525C433F5 for ; Fri, 19 Nov 2021 11:08:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7456161108 for ; Fri, 19 Nov 2021 11:08:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7456161108 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8886F6E03C; Fri, 19 Nov 2021 11:08:53 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id E74FB6E03C for ; Fri, 19 Nov 2021 11:08:52 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 6302260F57; Fri, 19 Nov 2021 11:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637320132; bh=MGQP/hrtX2By1G+IloWa4tkqTreG55JKH01OWy6ztxc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jl02+0R1AL8nkIL4t2IOsnf3pKd35+snNFNW2PajI7tCbE2GtwAF8mOGDoy9o6IcF eIxCm1uaMy9pBDDEgvhcVNZyvcxphmaoHoDXZubLU7TWmEuVq10ru6ZgAbvfb5qlAX xZF937C0tKlKh6Ig9DI7PajMtcd1ianj0FfwjXCs= Date: Fri, 19 Nov 2021 12:08:49 +0100 From: Greg Kroah-Hartman To: Javier Martinez Canillas Subject: Re: [PATCH v5 3/6] drm: Move nomodeset kernel parameter to the DRM subsystem Message-ID: References: <20211112133230.1595307-1-javierm@redhat.com> <20211112133230.1595307-4-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pekka Paalanen , Jani Nikula , Daniel Vetter , Michel =?iso-8859-1?Q?D=E4nzer?= , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Peter Robinson , Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Nov 19, 2021 at 11:20:13AM +0100, Javier Martinez Canillas wrote: > [ adding gregkh to Cc list for drivers/video/console ] > > On 11/12/21 14:32, Javier Martinez Canillas wrote: > > The "nomodeset" kernel cmdline parameter is handled by the vgacon driver > > but the exported vgacon_text_force() symbol is only used by DRM drivers. > > > > It makes much more sense for the parameter logic to be in the subsystem > > of the drivers that are making use of it. > > > > Let's move the vgacon_text_force() function and related logic to the DRM > > subsystem. While doing that, rename it to drm_firmware_drivers_only() and > > make it return true if "nomodeset" was used and false otherwise. This is > > a better description of the condition that the drivers are testing for. > > > > Suggested-by: Daniel Vetter > > Signed-off-by: Javier Martinez Canillas > > Acked-by: Thomas Zimmermann > > Acked-by: Jani Nikula > > Acked-by: Pekka Paalanen > > --- > > > > Greg, could I please get your ack for this patch ? Acked-by: Greg Kroah-Hartman