From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93E9AC433F5 for ; Sat, 18 Dec 2021 13:49:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 32F96113823; Sat, 18 Dec 2021 13:49:32 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 94A2C11381E; Sat, 18 Dec 2021 13:49:30 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10201"; a="300698743" X-IronPort-AV: E=Sophos;i="5.88,216,1635231600"; d="scan'208";a="300698743" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2021 05:49:29 -0800 X-IronPort-AV: E=Sophos;i="5.88,216,1635231600"; d="scan'208";a="520154349" Received: from aluyckx1-mobl3.ger.corp.intel.com (HELO intel.com) ([10.251.213.45]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2021 05:49:26 -0800 Date: Sat, 18 Dec 2021 15:49:23 +0200 From: Andi Shyti To: Matt Roper Subject: Re: [PATCH v8 15/16] drm/i915: Use to_gt() helper for GGTT accesses Message-ID: References: <20211214193346.21231-1-andi.shyti@linux.intel.com> <20211214193346.21231-16-andi.shyti@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?Q?Micha=C5=82?= Winiarski , Andi Shyti , Intel GFX , Lucas De Marchi , DRI Devel , Chris Wilson , Andi Shyti Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Matt, > > diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c > > index 95174938b160..3c984553d86f 100644 > > --- a/drivers/gpu/drm/i915/i915_driver.c > > +++ b/drivers/gpu/drm/i915/i915_driver.c > > @@ -571,6 +571,8 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv) > > > > i915_perf_init(dev_priv); > > > > + intel_gt_init_hw_early(to_gt(dev_priv), &dev_priv->ggtt); > > + > > Does moving this call earlier in the function need to happen in patch > #13 rather than here? That patch converts the internals of > i915_ggtt_probe_hw() to use to_gt()->ggtt, but I believe until this > patch that pointer is uninitialized. yes... you cought me lazy... I will move it to #13. Thanks, Andi